| Age | Commit message (Collapse) | Author |
|---|
|
|
|
This reverts commit 3b4701b240f55b4e97edee7fdc13fec35a76fc5a.
|
|
This is not the right way to do i18n. Banners are difficult and buggy
with translations, the folder structure is wrong and the result is
duplicated markup.
For the sake of maintainability, I am liberally removing this from core.
Future i18n attempts should use real gettext implementations and
possibly seperate i18n files from core as an extension.
Because Cupkle contributed the Catalan translation, this also removes
him/her from contributors.
|
|
This fixes a silly validation error that was introduced in last commit.
The javascript:; is reduntant anyway.
|
|
There seems to be no meaning to having this <span> element here with no
styling applied to it. It doesn't have anything to do with drag and drop
functionality either, and nothing seems to be broken after removing it.
|
|
Corrects semantics and increases accessibility.
The <a> element represents a hyperlink. A hyperlink is "a link from a
hypertext file or document to another location or file." This is not
what #upload-btn is, it's a button.
Ask yourself: "Does the element change the URL?" In our case, the upload
button does not so it is incorrect to use an <a> element here.
The idea to use <a> elements as buttons comes from years ago when you
couldn't style <button> elements in legacy browsers. Today you can, so
there's no reason to break the semantics.
Reference: http://blogs.ancestry.com/techroots/buttons-vs-anchors/
|
|
|
|
|
|
|
