| Age | Commit message (Collapse) | Author |
|---|
|
Add comments explaining how the number 500 after Exception means HTTP
status code "500 Internal Server Error". This may not be so obvious to
the reader without consulting the PHP manual.
Compliments commit 4606553f38909b483bc06674f9558ede1a9ff1f6.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Sometimes I have been slightly inconsistent and used 72 characters limit
for wrapping. The 72 character line wrap is a habit from emails. The
intention is to use 80 characters for change logs.
|
|
Add PHPDoc DocBlocks feature to 2.1.0 added features (merge commit
52a6916abe3a9fe74c4d86bee5536557c7a6fa5d).
|
|
get_sha1() was deprecated in a5314a2ff4cb503ff41da13ffd0e907f49ee4009,
so formally $sha1 was also formally deprecated but not commented.
Clarify we really want to deprecate $sha1 too.
Updates CHANGELOG.md.
|
|
- Extend and improve PHP code comments (PHPDoc)
- Add Pantsu.cat copyright year 2016 for recent change
- UploadedFile: Fix typo SHA1 to SHA-1
- Response: Clarify what http_response_code(200); is
Reviewed-by: Austin Gillmann <alucard@cuntflaps.me>
|
|
Add a comment explaining how HTTP status code 200 means success.
|
|
This typo has been around for a while. Well, not anymore.
|
|
Claiming copyright for parts of UploadedFile.class.php and
settings.inc.php as per previous change, which introduced PHPDoc
comments.
The other files where edits were made in previous commits are
non-substantial and thus most likely not under copyright.
|
|
Add file summaries, @copyright tags and other comments. Covers majority
of the PHP code base now. I have avoided being too verbose and omitted
some potential tags.
Most visibly to the user, this comments every user configurable setting
and clarifies what some of the options do.
POMF_DB_USER and POMF_DB_PASS are not rendered perfectly in
phpDocumentor version 2.8.5. This is a sacrifice I made in attempt for
not being too verbose and obvious.
Response class gets a @todo for being a god object.
|
|
Add two topics merged recently to master:
- Merge branch 'wub/refactor-upload_file'
- Replace include_once statements with require_once
Signed-off-by: Juuso Lapinlampi <wub@partyvan.eu>
Signed-off-by: Austin Gillmann <alucard@cuntflaps.me>
Reviewed-by: Austin Gillmann <alucard@cuntflaps.me>
|
|
Normally in include_once if a script does not load PHP will treat it as
such as an E_WARNING, while require_once fail the script with a
E_COMPILE_ERROR if the script does not load.
Since we require all of these scripts to properly function it
will be better to classify them as required in PHP.
Reported-by: Juuso Lapinlampi <wub@partyvan.eu>
Reviewed-by: Juuso Lapinlampi <wub@partyvan.eu>
|
|
- upload.php: Unnest upload_file() if-else expressions
- upload.php: Apply DRY to POMF_FILES_ROOT.$newname
- upload.php: Add Pantsu.cat copyright year 2016
Reviewed-by: Austin Gillmann <alucard@cuntflaps.me>
Tested-by: Austin Gillmann <alucard@cuntflaps.me>
|
|
Previous two commits in this topic branch introduced substantial
changes.
|
|
Don't repeat yourself with multiple POMF_FILES_ROOT.$newname for full
file path. Use a variable pointer $uploadFile.
Improves code readability and robustness.
|
|
As phpmd (PHP Mess Detector) linter says: "An if expression with an else
branch is never necessary." Well, at least almost never necessary.
Improves readability and resolves phpmd cleancode lint errors.
|
|
- CHANGELOG: Update 2.0.2 changelog (Bootstrap license)
- CHANGELOG: Add Pomf 2.0.2 release date (today)
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Sync with Pomf 2.0.x maint branch.
- package.json: Change version to 2.0.2
(Essentially, this merge is for git-describe(1).)
|
|
Pomf 2.0.2 has been released today and tagged v2.0.2.
|
|
This marks the Pomf 2.0.2 release.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
See: 25ec99f6f8b184dc29804358185104c800f2bcdb
|
|
Sync with Pomf 2.0.x maint branch.
- css: Add missing Bootstrap license header (Expat)
|
|
Bootstrap is a CSS framework by Twitter, Inc.
Pomf uses certain Bootstrap 3 elements, such as .jumbotron and .alert.
The credit is due for Twitter, Inc. for Bootstrap, which like Pomf is
free software licensed under the Expat license.
The CSS snippets about Bootstrap were initially introduced to
style.min.css in commit df6cf936d7ef3a819c6ff484b24a8cb5946726a9, then
moved into pomf.css uncompressed in commit
152c0257a8ef9a8da7e45717a65578c340a7c178.
See: https://getbootstrap.com/
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
One v1.0.0 change log line was too long and to wrapped to 80 characters.
Fixes commit e09581c06b8340309f86d2dc3ef2a5cd4defeaae.
|
|
- CHANGELOG: Add full change logs for 1.0.0+8757e9a
- CHANGELOG: Track changes to v1.0.0 instead of 1.0.0
- CHANGELOG: Add Pomf 1.0.0 changes since initial commit
(ewhal@ admitted he's not going to spend four hours into reviewing the
accuracy of these commits, but gave me an OK.)
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Replaces 1.0.0+8757e9a change log stub with verbose, full change logs.
I am so glad I did not have to write every single moe panel change and
README.md comment about how moe panel is shit into these logs. The
commit history is awful around v1.0.0 and 1.0.0+8757e9a.
There are some things here that I took liberally, for example cenci0's
case 413 decoding hack which in turn was actually a bug itself and fixed
later in 2.0.x. So, I simply called it a "HTML validation" fix.
While we are here, clarify that there was no formal release for this
version.
|
|
As explained in v1.0.0 tag message, the 1.0.0 tag is incorrectly
positioned to mark a release. v1.0.0 is the superset at the point when
it was merged to nokonoko/Pomf.
|
|
Replaces stub 1.0.0 change logs with verbose ones.
tits.php was added but then removed before it made into the 1.0.0
"release", and thus not mentioned in these change logs.
Grunt was added in, but Swig pages only came in the next commit and the
Git history is linear rather than branched. Thus, 1.0.0's Grunt build
system is "broken" and only partially implemented.
|
|
See: 617c4409e76b4a86316c81b50ff1edca70b329e2
|
|
Sync with Pomf 2.0.x maint branch fixes.
- README: Add #pomf on Partyvan to getting help
|
|
It turns out that moving to Rizon's IRC network was a bad idea after
all. One or more developers (myself included) are unable to connect to
Rizon for using Tor or operating Tor exits.
Now there's this split: Users and Pomf site maintainers are on #pomfret
on Rizon (where I don't have frequent access) and development has moved
back to #pomf on Partyvan (where there's also #/g/hostingtalk).
Given how I personally play such a big role in leading Pomf development,
it has no longer been practical to continue development communication on
an IRC network I can't access. There was no interest to finish setting
up a mailing list for Pomf development because IRC was considered more
important.
Thus, the stagnation and stalled development of pantsu/pomf between
2016-01-31 and 2016-04-30 as seen in commit logs.
There used to be an IRC channel called #pantsucat on Partyvan's IRC
network, before development moved to Rizon. That channel is no longer
active.
See: pantsu/pomf@5846ba7ccb1aa6af2850b3fcf34c6bd396995161
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
|
|
camelCase is the preferred coding style for function names in the PSR-2
coding style guide used by Pomf since version 2.0.0.
Reference: http://www.php-fig.org/psr/psr-2/
|
|
There are two issues with get_sha1():
- The function name doesn't follow the PSR-2 coding style guide for
function naming, followed in Pomf since version 2.0.0.
- SHA-1 is no longer considered resilient to collisions, versus SHA-256.
In current plans, this feature is to be replaced with getHash() or
similar function name in the next major version (Pomf 3.0.0).
For consideration for future SHA-256 hashing implementation, the MySQL
schema's hash value needs to be changed from char(40) to char(64) to
accommodate the longer SHA-256 length of 64 bytes in hexadecimal string.
|
|
|
|
File expiration support has never been properly implemented in Pomf core
or moe panel. It serves as legacy baggage before nekunekus got an idea
to create nokonoko/Uguu for temporary uploads.
In current plans, this non-feature will be removed in the 3.0.0 release
which is the next SemVer major version that allows to remove this.
Reviewed-by: Austin Gillmann <alucard@cuntflaps.me>
|
|
Fixes commit 6495e3a214e6c745f06a9b842ef2e59a9c116c7c.
Also fix the incorrect name of Gruntfile to Gruntfile.js.
Reference:
http://www.cirosantilli.com/markdown-style-guide/#what-to-mark-as-code
|
|
- CHANGELOG: Add notes for unreleased 2.0.2 so far
- CHANGELOG: Update notes for unreleased 2.1.0 so far
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Add a mention about HTML metadata generator value.
|
|
|
|
Sync with latest maint branch bugfixes.
- Fix/Update LibreJS @source URL to cgit tree
- Change package.json bugs contact to bugs@pantsu.cat email, remove URL
- package.json: Use lowercase pomf for package name
- Gruntfile: Sort grunt-swig options alphabetically
Conflicts:
Gruntfile.js
|
|
Code cleanup, that's all.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
One of NPM's rules [1] is: "New packages must not have uppercase letters
in the name." This also follows the convention where Git repository
names are lowercase.
This change is mostly irrelevant to us, but it's a bug nonetheless.
There's no concern over backwards compatibility regarding SemVer as far
as I'm aware.
This bug was introduced in 7d28ef53a8166cbdcb558a84d5a53cfd73472438.
[1]: https://docs.npmjs.com/files/package.json
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Actually on second thought, SemVer doesn't allow us to remove
functionality without incrementing the major version number... which we
don't want to do for this.
Set the bugs email address to bugs@pantsu.cat. Hoping here bugs@ to be
an alias to ewhal@ for the time being until a real mailing list will be
reachable at that address. This fixes the issue for the time being
without removing functionality.
It is okay that we made a mistake. We don't need to increment the major
version here now, because no release was tagged and released in this
branch.
Nevermind that Pomf isn't even published on NPM packages, so this
"feature" is never seen in its current form in the npm(1) program. We'll
still respect SemVer, for what little worth it may be to other tools.
This reverts commit 310d8d9fdd33826b9a6d5c1f9b1f8aa1c373c461.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Why is this a thing? We never used pantsu/pomf issue tracking. It was
disabled a long time ago in gogs, and now it doesn't even exist.
For consideration, we could provide an email address here. There's no
mailing list for bugs (yet) and it's unlikely to see one soon.
Compliments commit bf4fbf5f8718c4668a57d7dc09880deb904fef1b. Inspired by
~alucard/pomf at Cuntflaps, though never reported to us.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
git.pantsu.cat has switched from gogs to cgit. gogs used a slightly
different URLs to point to tree, so the old URLs from gogs are no longer
valid.
For consideration, to ease maintenance we'll just keep pointing the URL
to the master branch and not a specific commit or maint branch.
?h=master is not really required here, it's the default branch. I am
aware that the current maint and master branches diverge heavily from
each other in terms of JavaScript, but this will be an issue that will
disappear eventually. Thus, this is the simplest fix.
A HTTP redirect will be setup for the old URL to the new one
(eventually) to fix broken links.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Sync with v2.0.1 maint branch.
Doing this sync any later would make me insane and lost.
|
|
Add `<meta name="generator" value="Pomf x.y.z">` to page layout, where
x.y.z is the current Pomf version number defined in package.json with
the help of Grunt.
This change is done to satisfy WHATWG's HTML standard, section 4.2.5.1
Standard metadata names.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Instead of hardcoding the version number and duplicating version strings
in markup, have Grunt grab the version value from package.json. Adds
Gruntfile value pkgVersion.
For consideration, this will cause some issues in efforts to remove
Grunt from Pomf 3.x branch. Right now it's still considerably the best
or simplest thing we can do.
Suggested-by: Eliot Whalan <ewhal@pantsu.cat>
Suggested-by: Austin Gillmann <alucard@cuntflaps.me>
|
|
WHATWG's HTML standard vaguely implies in section "4.2.5.1 Standard
metadata names" that documents that lack a metadata generator value were
written by a user in a text editor. This is not the case for Pomf.
The next Pomf release is expected to be version 2.1.0, which was picked
here for the value.
While we are here, update copyright year to 2016 for this template.
|
|
I have a belief that Swig banners are a Grunt only thing, and they don't
really integrate very well into Swig anyway. It's kind of a hack, and a
bad one because we don't need it anymore.
By deprecating Swig banners, we should have easier time replacing
Grunt/npm with Make in a future release.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
