summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJuuso Lapinlampi <wub@partyvan.eu>2016-05-07 16:40:25 +0200
committerJuuso Lapinlampi <wub@partyvan.eu>2016-05-07 17:49:02 +0200
commita5314a2ff4cb503ff41da13ffd0e907f49ee4009 (patch)
tree224ff0cb38f4726ce6ee5992854252d1e1e3e6dc
parent59ac83bf77ea1026e254f7b5419c4d30673a2bf5 (diff)
Deprecate get_sha1() in Pomf 2.1.0
There are two issues with get_sha1(): - The function name doesn't follow the PSR-2 coding style guide for function naming, followed in Pomf since version 2.0.0. - SHA-1 is no longer considered resilient to collisions, versus SHA-256. In current plans, this feature is to be replaced with getHash() or similar function name in the next major version (Pomf 3.0.0). For consideration for future SHA-256 hashing implementation, the MySQL schema's hash value needs to be changed from char(40) to char(64) to accommodate the longer SHA-256 length of 64 bytes in hexadecimal string.
-rw-r--r--CHANGELOG.md2
-rw-r--r--static/classes/UploadedFile.class.php1
2 files changed, 3 insertions, 0 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5b1594f..d4c935f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -22,6 +22,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).
- Swig banners. Use Swig templates or an alternative. (Juuso Lapinlampi)
- Unused file expiration (`expire`). This feature may be removed in the
next major version. (Juuso Lapinlampi)
+- `get_sha1()` function. This API may be changed or removed in the next
+ major version, switching to SHA-256 hashes. (Juuso Lapinlampi)
## `2.0.2` - Unreleased
diff --git a/static/classes/UploadedFile.class.php b/static/classes/UploadedFile.class.php
index ac39646..99020ce 100644
--- a/static/classes/UploadedFile.class.php
+++ b/static/classes/UploadedFile.class.php
@@ -37,6 +37,7 @@ class UploadedFile
/**
* Generates the SHA1 or returns the cached SHA1 hash for the file.
*
+ * @deprecated 2.1.0 To be replaced with SHA-256 hashing.
* @return string
*/
public function get_sha1()