JSON-ify the default invalid response type error

Code re-use is good. The previous implementation doesn't reuse existing
text_error() functions and also forgoes using text/plain header with the
text implementation.

This fixes consistency where JSON is assumed to be the default output.
It is a common practice among APIs to default all errors to JSON, such
as the Stripe and Tumblr APIs.

1 files changed, 3 insertions, 2 deletions

diff --git a/static/classes/Response.class.php b/static/classes/Response.class.php
index cd9229b..a4e19b5 100755
--- a/static/classes/Response.class.php
+++ b/static/classes/Response.class.php
@@ -50,8 +50,9 @@ class Response
                 $this->type = $response_type;
                 break;
             default:
-                http_response_code(400);
-                echo 'Invalid response type. Valid options are: csv, html, json, text.';
+                header('Content-Type: application/json; charset=UTF-8');
+                $this->type = 'json';
+                $this->error(400, 'Invalid response type. Valid options are: csv, html, json, text.');
                 break;
         }
     }