From 5b77a4eaab418836820b2a0bad7c88f0b88136a0 Mon Sep 17 00:00:00 2001 From: cenci0 Date: Tue, 3 Feb 2015 21:39:47 +0100 Subject: Minor code refactoring and updates DATABASE UPDATE: `orginalname` renamed to `originalname` (run update.sql to update `files` table). Run `update.sql` to update your database, no data will be lost (if you don't update it, pomf won't work properly). `schema.sql` - `id`s are now unsigned to double the maximum number of supported indexes - `size` and `user` columns are unsigned too (we can't have a negative file size or a negative user id) `static/classes/Response.class.php` New class to manage responses and errors. Using a class for responses makes the code cleaner and easier to add new response type handlers in the future. - The response type is declared while a new variable is initialized and the `error` and `send` methods will print a proper output according to it - The header for the response is also set accordingly to the response type (`text/plain` for `csv`/`gyazo` output, `application/json` for `json` output) `static/classes/UploadException.class.php` `Exception` class extension to manage errors that may have occurred while uploading files to the server. This way every error is reported in detail. `static/includes/settings.inc.php` - `POMF_URL`: add an option to set the domain of the url to prepend to the newly generated filename (before it was hardcoded and it was `http://a.pomf.se/`) [this option is currently used only when the output is set to `gyazo`] `upload.php` - Add functions calls at the beginning to enable the output compression if possible (gzipped output) - Include new classes - `generate_name ()` --- The new name generation algorithm is basically the same of the old one, but it's easier to add/remove characters if needed (eg. lower-case letters isn't enough and you need to add capital-case letters or digits) --- Check directly the database instead of the filesystem to see if a generated filename is already in use - `upload_file ()` --- File errors generate a `UploadException` instead of a normal `Exception` --- Move common code outside the `if` to avoid useless code repetition (only the query is now inside the condition) --- Change file permissions of a file after moving it to the new directory (if the user didn't set a mask previouly these files wouldn't be world readable, we make sure they are) - `diverse_array ()` --- Function to reorder initial `$_FILES` array (easier to handle for `refiles`) - `refiles ()` --- Use a `foreach` cicle instead of a `for` one, easier to understand - Create a new response object and set its response type (`csv`, `gyazo` or default to `json`) - Edit response handling according to the new response class --- update.sql | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100755 update.sql (limited to 'update.sql') diff --git a/update.sql b/update.sql new file mode 100755 index 0000000..ac4d548 --- /dev/null +++ b/update.sql @@ -0,0 +1,16 @@ +ALTER TABLE `accounts` +CHANGE COLUMN `id` `id` int(10) unsigned NOT NULL auto_increment; + +ALTER TABLE `files` +CHANGE COLUMN `id` `id` int(10) unsigned NOT NULL auto_increment, +CHANGE COLUMN `orginalname` `originalname` varchar(255) NULL default NULL, +CHANGE COLUMN `size` `size` int(10) NULL default NULL, +CHANGE COLUMN `user` `user` int(10) NULL default '0'; + +ALTER TABLE `invites` +CHANGE COLUMN `id` `id` int(10) unsigned NOT NULL auto_increment; + +ALTER TABLE `reports` +CHANGE COLUMN `id` `id` int(10) unsigned NOT NULL auto_increment, +CHANGE COLUMN `file` `file` varchar(255) NOT NULL, +CHANGE COLUMN `reporter` `reporter` varchar(255) NOT NULL; \ No newline at end of file -- cgit v1.2.3