From f4504ac1229c0f0064fc5a7f80ebbd8a98427213 Mon Sep 17 00:00:00 2001 From: Juuso Lapinlampi Date: Wed, 25 May 2016 04:35:52 +0000 Subject: upload.php: Deprecate ob_start (output buffering) None of us can find a reason why we would need to buffer our output in a PHP application. My best guess is this may be a relic from Pomf 1.0.0 or Moe panel. Unless someone finds a better reason to keep this, this feature is useless and has negligible benefit and will be removed. In respect for SemVer, deprecating this feature happens first in a minor version before removal in a next major version. Acked-by: Eliot Whalan --- static/upload.php | 1 + 1 file changed, 1 insertion(+) diff --git a/static/upload.php b/static/upload.php index 8b0646c..ebedeab 100644 --- a/static/upload.php +++ b/static/upload.php @@ -30,6 +30,7 @@ */ // Check if we can compress our output; if we can, we'll do it +// This feature is deprecated since version 2.1.0. if (ini_get('zlib.output_compression') !== 'Off' && isset($_SERVER['HTTP_ACCEPT_ENCODING']) && strpos($_SERVER['HTTP_ACCEPT_ENCODING'], 'gzip') !== false) { -- cgit v1.2.3 From 212dc87c10fe1f667e38637c9287cad3ce84e934 Mon Sep 17 00:00:00 2001 From: Juuso Lapinlampi Date: Wed, 25 May 2016 04:42:02 +0000 Subject: CHANGELOG: Update 2.1.0 up to f4504ac Add output buffering to 2.1.0 deprecated features. --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8cdc436..8c41b14 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -31,6 +31,8 @@ This project adheres to [Semantic Versioning](http://semver.org/). `json_success`, `text_error` and `text_success` functions. The functions will be renamed to `camelCase` format (e.g. `csvError`, `htmlSuccess`). (Juuso Lapinlampi) +- Output buffering (`ob_start`). This feature may be removed in the next + major version. (Juuso Lapinlampi) ### Fixed -- cgit v1.2.3