summaryrefslogtreecommitdiff
path: root/static
AgeCommit message (Collapse)Author
2017-01-21Delete redundent readmeAustin
2017-01-04Update licensesAustin Gillmann
2017-01-04Merge php submodule into pomf, delete expiry.Austin Gillmann
2016-07-05Fix small typos and add documentation for app.jsr3c0d3x
2016-07-04Cleared selection first upon copy button click to fix #45ileyd
2016-07-03have JS POST to upload.php in current working directoryAustin
2016-07-02Replace tabs with spaces as per airbnb css specEliot Whalan
2016-07-01Replace tabs with spaces as per airbnb specEliot Whalan
2016-06-29Switch copy button styling code to CSS fileAustin
2016-06-28Changed glyph to png formatileyd
2016-06-28Added copy iconileyd
2016-06-28Implemented clipboard supportileyd
2016-06-24Begin formatting fixup of js codeEliot Whalan
2016-06-19Move php directory to php/ to avoid confusionEliot Whalan
2016-06-18Remove zlib compression as it is already handled by nginxEliot Whalan
2016-06-17Removed redundant $uploadDir variable; put constant directly in $uploadFileakpu1
2016-06-17Move favicon to imgEliot Whalan
2016-06-17Create php fileEliot Whalan
2016-06-17Move img to static folderEliot Whalan
2016-06-17Move css to static folderEliot Whalan
2016-06-17Move js to static folderEliot Whalan
2016-06-17Rename all functions to camelCase as set by psr2Eliot Whalan
2016-06-16Revert most ofddccf5f1c26517bf58cd45e3d92096fc760d9db6Eliot Whalan
2016-06-14Revert "Remove now-dead code for kawaii grill images"Eliot Whalan
This reverts commit 79fbcfb4a236650b2ee48569729947878e997466.
2016-06-14Revert "upload.php: Deprecate all named functions"Eliot Whalan
This reverts commit cae3cb012812c2d7e1995301e85c8954567a499d.
2016-05-30Revert "Merge branch 'wub/deprecate-ewhal'"Eliot Whalan
This reverts commit 647d32a29978579f88baa7c06c207e6a8d6a0d3e, reversing changes made to 22063af06536671b680fa9bc84b4626192c106cc.
2016-05-29upload.php: Deprecate all named functionsJuuso Lapinlampi
Deprecates diverse_array(), generate_name(), refiles() and upload_file(). These pollute the global namespace and do not follow the PSR-2 naming convention. The plan is to create a new file with a new class to share this common code, leaving upload.php only with the last lines of code that it really needs to do (calling other class functions). Acked-by: Eliot Whalan <ewhal@pantsu.cat>
2016-05-29Merge branch 'wub/deprecate-ewhal'Juuso Lapinlampi
Deprecate (nearly) all things authored by Eliot Whalan. Misfeatures and customizations specifically used only by Pantsu.cat, and design choices where complexity and code duplication do not matter to achieve features easily are his efforts. Cue code maintenance hell. This merge includes: - pages: Bring back autistic neckbeard rant - pages: Deprecate JavaScript-free upload - pages: Deprecate other services - Response: Deprecate HTML and text responses Eliot disagrees with this merge and threatens to branch off development. No commits by ewhal@ since 2016 to today, only code reviews. Anything that extends Pomf core functionality should be a repository or a branch of its own, an extension. If later removed, HTML and text responses may be reintroduced as extensions (pomf-response-html, pomf-response-text repositories) or as different PHP files/classes once the code is stable enough to support those features in a sensible and maintainable way. The JavaScript-free uploader is a mess of duplicated Swig templates. The "other services" page is mainly only useful for Pantsu.cat. I love autistic neckbeards. Then there's this quote: ewhal4 | I've made pantsu.cat as autism friendly as possible and now you are removing it :( Preliminary, I welcome to follow ~wub/pomf.git if development branches off from here.
2016-05-29upload.php: Don't unlink() tempfiles in upload_file()Juuso Lapinlampi
We don't need to care about garbage collection and explicitly unlinking temporary files: PHP will handle that for us automatically. In other words, this is "dead" code. Less code the better. Updates the comment before it to reflect this. Tested on PHP 5.6.22 and PHP 7.0.7 on Debian stretch/sid GNU/Linux. Tested-by: Juuso Lapinlampi <wub@partyvan.eu> See: https://secure.php.net/manual/en/function.tmpfile.php
2016-05-29Response: Deprecate HTML and text responsesJuuso Lapinlampi
HTML and text responses were introduced by Eliot to Pomf 2.0 primarily for the JavaScript-free uploader (which is also deprecated). I can't imagine any sane tool preferring to have either of these flawed responses over JSON or CSV. They increase code complexity and duplication. Let them fall off. ewhal fell off. Cc: Eliot Whalan <ewhal@pantsu.cat>
2016-05-29Merge branch 'maint'Juuso Lapinlampi
Sync with Pomf 2.0.x maint branch. - Response: Return 500 Internal Server Error on error()
2016-05-29Response: Clarify what http_response_code(200); isJuuso Lapinlampi
Add a comment explaining how HTTP status code 200 means success. Cherry-picked from master 4606553f38909b483bc06674f9558ede1a9ff1f6.
2016-05-29Response: Return 500 Internal Server Error on error()Juuso Lapinlampi
Fix a bug where Response class `error()` function may blow up and return an invalid HTTP status code `42` if `PDO::ATTR_ERRMODE` is set to `PDO::ERRMODE_EXCEPTION` during PDO initialization or query. By default, it is implicitly set to `PDO::ERRMODE_SILENT`. This bug can occur when a MySQL server is running, but encounters an error post-login (e.g. table doesn't exist).
2016-05-25upload.php: Deprecate ob_start (output buffering)Juuso Lapinlampi
None of us can find a reason why we would need to buffer our output in a PHP application. My best guess is this may be a relic from Pomf 1.0.0 or Moe panel. Unless someone finds a better reason to keep this, this feature is useless and has negligible benefit and will be removed. In respect for SemVer, deprecating this feature happens first in a minor version before removal in a next major version. Acked-by: Eliot Whalan <ewhal@pantsu.cat>
2016-05-25upload.php: Clarify what Exception $code 500 isJuuso Lapinlampi
Add comments explaining how the number 500 after Exception means HTTP status code "500 Internal Server Error". This may not be so obvious to the reader without consulting the PHP manual. Compliments commit 4606553f38909b483bc06674f9558ede1a9ff1f6. Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
2016-05-25Response: Deprecate $sha1Juuso Lapinlampi
get_sha1() was deprecated in a5314a2ff4cb503ff41da13ffd0e907f49ee4009, so formally $sha1 was also formally deprecated but not commented. Clarify we really want to deprecate $sha1 too. Updates CHANGELOG.md.
2016-05-25Response: Clarify what http_response_code(200); isJuuso Lapinlampi
Add a comment explaining how HTTP status code 200 means success.
2016-05-24UploadedFile: Fix typo SHA1 to SHA-1Juuso Lapinlampi
This typo has been around for a while. Well, not anymore.
2016-05-24Add Pantsu.cat copyright year 2016 for recent changeJuuso Lapinlampi
Claiming copyright for parts of UploadedFile.class.php and settings.inc.php as per previous change, which introduced PHPDoc comments. The other files where edits were made in previous commits are non-substantial and thus most likely not under copyright.
2016-05-24Extend and improve PHP code comments (PHPDoc)Juuso Lapinlampi
Add file summaries, @copyright tags and other comments. Covers majority of the PHP code base now. I have avoided being too verbose and omitted some potential tags. Most visibly to the user, this comments every user configurable setting and clarifies what some of the options do. POMF_DB_USER and POMF_DB_PASS are not rendered perfectly in phpDocumentor version 2.8.5. This is a sacrifice I made in attempt for not being too verbose and obvious. Response class gets a @todo for being a god object.
2016-05-23Replace include_once statements with require_onceAustin Gillmann
Normally in include_once if a script does not load PHP will treat it as such as an E_WARNING, while require_once fail the script with a E_COMPILE_ERROR if the script does not load. Since we require all of these scripts to properly function it will be better to classify them as required in PHP. Reported-by: Juuso Lapinlampi <wub@partyvan.eu> Reviewed-by: Juuso Lapinlampi <wub@partyvan.eu>
2016-05-23upload.php: Add Pantsu.cat copyright year 2016Juuso Lapinlampi
Previous two commits in this topic branch introduced substantial changes.
2016-05-23upload.php: Apply DRY to POMF_FILES_ROOT.$newnameJuuso Lapinlampi
Don't repeat yourself with multiple POMF_FILES_ROOT.$newname for full file path. Use a variable pointer $uploadFile. Improves code readability and robustness.
2016-05-23upload.php: Unnest upload_file() if-else expressionsJuuso Lapinlampi
As phpmd (PHP Mess Detector) linter says: "An if expression with an else branch is never necessary." Well, at least almost never necessary. Improves readability and resolves phpmd cleancode lint errors.
2016-05-07Deprecate underscores in PHP function namesJuuso Lapinlampi
camelCase is the preferred coding style for function names in the PSR-2 coding style guide used by Pomf since version 2.0.0. Reference: http://www.php-fig.org/psr/psr-2/
2016-05-07Deprecate get_sha1() in Pomf 2.1.0Juuso Lapinlampi
There are two issues with get_sha1(): - The function name doesn't follow the PSR-2 coding style guide for function naming, followed in Pomf since version 2.0.0. - SHA-1 is no longer considered resilient to collisions, versus SHA-256. In current plans, this feature is to be replaced with getHash() or similar function name in the next major version (Pomf 3.0.0). For consideration for future SHA-256 hashing implementation, the MySQL schema's hash value needs to be changed from char(40) to char(64) to accommodate the longer SHA-256 length of 64 bytes in hexadecimal string.
2016-05-07Deprecate file expiration support in Pomf 2.1.0Juuso Lapinlampi
File expiration support has never been properly implemented in Pomf core or moe panel. It serves as legacy baggage before nekunekus got an idea to create nokonoko/Uguu for temporary uploads. In current plans, this non-feature will be removed in the 3.0.0 release which is the next SemVer major version that allows to remove this. Reviewed-by: Austin Gillmann <alucard@cuntflaps.me>
2016-01-27Fix undeclared vars in html_success() and text_success()Juuso Lapinlampi
As explained by clsr: > <clsr> With default PHP settings, that'd print a warning, then treat > $result as if it was an empty string before appending. This bug was introduced in commit a92961f24072bc4c3881bf0e2f609562f3703471 and 1411bce1dc13bf6fea66b5899ba29d50d5c53bb0. Reported-by: clsr <clsr@clsr.net> Suggested-by: clsr <clsr@clsr.net>
2016-01-27Add missing newline to Response.class.phpJuuso Lapinlampi
Right before text_error(), there was a missing newline. This bug was introduced in commit a92961f24072bc4c3881bf0e2f609562f3703471.
2016-01-06Amend year 2016 to Response/LICENSE copyrightJuuso Lapinlampi
New code has been added to Response.class.php this year in commit b94ac9a. Update LICENSE and Response.class.php copyright header with year 2016. We can't do this for every file in the project repository unless they are actually changed, due to the way our copyright legislation works. We also can't remove the mention of 2015, because most of the code was initially published in 2015 and so remains copyrighted since that year.