| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
feel bad.
|
|
|
|
it returns status code other than 200 OK.
|
|
(modelled after GNU MediaGoblin).
|
|
in a database.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This reverts commit 79fbcfb4a236650b2ee48569729947878e997466.
|
|
This reverts commit cae3cb012812c2d7e1995301e85c8954567a499d.
|
|
This reverts commit 647d32a29978579f88baa7c06c207e6a8d6a0d3e, reversing
changes made to 22063af06536671b680fa9bc84b4626192c106cc.
|
|
Deprecates diverse_array(), generate_name(), refiles() and
upload_file(). These pollute the global namespace and do not follow the
PSR-2 naming convention.
The plan is to create a new file with a new class to share this common
code, leaving upload.php only with the last lines of code that it really
needs to do (calling other class functions).
Acked-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Deprecate (nearly) all things authored by Eliot Whalan. Misfeatures and
customizations specifically used only by Pantsu.cat, and design choices
where complexity and code duplication do not matter to achieve features
easily are his efforts. Cue code maintenance hell.
This merge includes:
- pages: Bring back autistic neckbeard rant
- pages: Deprecate JavaScript-free upload
- pages: Deprecate other services
- Response: Deprecate HTML and text responses
Eliot disagrees with this merge and threatens to branch off development.
No commits by ewhal@ since 2016 to today, only code reviews.
Anything that extends Pomf core functionality should be a repository or
a branch of its own, an extension.
If later removed, HTML and text responses may be reintroduced as
extensions (pomf-response-html, pomf-response-text repositories) or as
different PHP files/classes once the code is stable enough to support
those features in a sensible and maintainable way.
The JavaScript-free uploader is a mess of duplicated Swig templates.
The "other services" page is mainly only useful for Pantsu.cat.
I love autistic neckbeards. Then there's this quote:
ewhal4 | I've made pantsu.cat as autism friendly as possible and now
you are removing it :(
Preliminary, I welcome to follow ~wub/pomf.git if development branches
off from here.
|
|
We don't need to care about garbage collection and explicitly unlinking
temporary files: PHP will handle that for us automatically. In other
words, this is "dead" code. Less code the better.
Updates the comment before it to reflect this.
Tested on PHP 5.6.22 and PHP 7.0.7 on Debian stretch/sid GNU/Linux.
Tested-by: Juuso Lapinlampi <wub@partyvan.eu>
See: https://secure.php.net/manual/en/function.tmpfile.php
|
|
HTML and text responses were introduced by Eliot to Pomf 2.0 primarily
for the JavaScript-free uploader (which is also deprecated).
I can't imagine any sane tool preferring to have either of these flawed
responses over JSON or CSV. They increase code complexity and
duplication. Let them fall off.
ewhal fell off.
Cc: Eliot Whalan <ewhal@pantsu.cat>
|
|
Sync with Pomf 2.0.x maint branch.
- Response: Return 500 Internal Server Error on error()
|
|
Add a comment explaining how HTTP status code 200 means success.
Cherry-picked from master 4606553f38909b483bc06674f9558ede1a9ff1f6.
|
|
Fix a bug where Response class `error()` function may blow up and return
an invalid HTTP status code `42` if `PDO::ATTR_ERRMODE` is set to
`PDO::ERRMODE_EXCEPTION` during PDO initialization or query. By default,
it is implicitly set to `PDO::ERRMODE_SILENT`.
This bug can occur when a MySQL server is running, but encounters an
error post-login (e.g. table doesn't exist).
|
|
None of us can find a reason why we would need to buffer our output in a
PHP application. My best guess is this may be a relic from Pomf 1.0.0 or
Moe panel.
Unless someone finds a better reason to keep this, this feature is
useless and has negligible benefit and will be removed.
In respect for SemVer, deprecating this feature happens first in a minor
version before removal in a next major version.
Acked-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Add comments explaining how the number 500 after Exception means HTTP
status code "500 Internal Server Error". This may not be so obvious to
the reader without consulting the PHP manual.
Compliments commit 4606553f38909b483bc06674f9558ede1a9ff1f6.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
get_sha1() was deprecated in a5314a2ff4cb503ff41da13ffd0e907f49ee4009,
so formally $sha1 was also formally deprecated but not commented.
Clarify we really want to deprecate $sha1 too.
Updates CHANGELOG.md.
|
|
Add a comment explaining how HTTP status code 200 means success.
|
|
This typo has been around for a while. Well, not anymore.
|
|
Claiming copyright for parts of UploadedFile.class.php and
settings.inc.php as per previous change, which introduced PHPDoc
comments.
The other files where edits were made in previous commits are
non-substantial and thus most likely not under copyright.
|
|
Add file summaries, @copyright tags and other comments. Covers majority
of the PHP code base now. I have avoided being too verbose and omitted
some potential tags.
Most visibly to the user, this comments every user configurable setting
and clarifies what some of the options do.
POMF_DB_USER and POMF_DB_PASS are not rendered perfectly in
phpDocumentor version 2.8.5. This is a sacrifice I made in attempt for
not being too verbose and obvious.
Response class gets a @todo for being a god object.
|
|
Normally in include_once if a script does not load PHP will treat it as
such as an E_WARNING, while require_once fail the script with a
E_COMPILE_ERROR if the script does not load.
Since we require all of these scripts to properly function it
will be better to classify them as required in PHP.
Reported-by: Juuso Lapinlampi <wub@partyvan.eu>
Reviewed-by: Juuso Lapinlampi <wub@partyvan.eu>
|
|
Previous two commits in this topic branch introduced substantial
changes.
|
|
Don't repeat yourself with multiple POMF_FILES_ROOT.$newname for full
file path. Use a variable pointer $uploadFile.
Improves code readability and robustness.
|
