| Age | Commit message (Collapse) | Author |
|---|
|
This reverts commit 647d32a29978579f88baa7c06c207e6a8d6a0d3e, reversing
changes made to 22063af06536671b680fa9bc84b4626192c106cc.
|
|
The tools page is long-hated from a Pomf maintainer perspective. URLs
are rarely long lived, tools fall unsupported quickly, every Pomf clone
tries to furiously make its own edits to the tools page etc. It's awful.
Let's remind that Pomf's primary scope is a file uploader, not a
collection of tools. A third-party site can list the available and
supported tools, and it can be a collaborated effort.
At this point, the API isn't even stable to support any tools. All the
API functions are deprecated at this point, and the upload end-point
/upload.php is to be phased away into some other saner URI which doesn't
rely on PHP to be used 20 years later. These tools very likely won't be
supported later.
Please don't even mention about ShareX source code and Git commit
messages. You'll cry.
Lastly someone may complain about a years old unsupported Pomf release
that no longer gets updates, and how their tool in the tools page is
wrong or broken despite the tool supporting the older API. You'll get my
point: this is not a Pomf core feature, but an extension.
ewhal fell off.
Cc: Eliot Whalan <ewhal@pantsu.cat>
|
|
The other services page was introduced in Pomf 2.0 as a customization
for Pantsu.cat, pushed to master branch as a misled approach to
development. There's no good reason to keep this as a Pomf core feature.
ewhal fell off.
Cc: Eliot Whalan <ewhal@pantsu.cat>
|
|
JavaScript-free uploading was introduced in Pomf 2.0 as a misfeature. It
increases complexity of the API code base and duplicates some code.
This was obviously a misled approach to Pomf development. The
recommended approach to solving this issue is using the upload API with
external tools.
ewhal fell off.
Cc: Eliot Whalan <ewhal@pantsu.cat>
|
|
The return of the almost legendary autistic neckbeard rant loved or
hated by everyone. Shown to noscript users.
This bug was introduced in the following commits:
- Rephrase check_script.swig JavaScript warning (6c3491c)
- Remove unnecessary paragraphs (254760b)
- Add link to JS free version (55fb54d)
This also fixes a grammar issue found in the previous iteration of this
feature: "autist neckbeard" -> "autistic neckbeard".
ewhal fell off.
Cc: Eliot Whalan <ewhal@pantsu.cat>
|
|
The FAQ page already unabbreviates the FAQ abbreviation. This aids
screen readers to pronounce the abbreviation correctly to increase
comprehension and adds semantics.
Acked-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Sync with Pomf 2.0.x maint branch.
- pages: Add a non-breaking space before "MiB"
Corrects a typo and adds the missing space character to index.
|
|
Fixes a typo where the unit symbol was missing a space character before
it.
To avoid automatic line breaks in text "128 MiB", a non-breaking space
character is used instead of a regular space character. If the text
doesn't fit at the end of a line it is moved in its entirety to the next
line.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Sync with Pomf 2.0.x maint branch.
- pages: Add Japanese HTML lang attribute to "baka"
Corrects pronunction by screen readers and improves semantics.
|
|
Corrects pronunction by screen readers and improves semantics.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Sync with Pomf 2.0.x maint branch.
- FAQ: Add Pantsu.cat copyright year 2016
|
|
These commits made some recent changes to the FAQ in year 2016:
- FAQ: Change non-abuse contact to info@pantsu.cat
- FAQ: Avoid using word "content" as a noun
These may be covered by copyright.
|
|
Set a good example and use info@ for the non-abuse contact. This is an
RFC 2142-ification, which I for long wanted ewhal to do but he
previously did not do for some reason.
contact@ is not an RFC 2142 recognized mailbox name.
See: https://tools.ietf.org/html/rfc2142
|
|
Sync with Pomf 2.0.x maint branch.
- FAQ: Avoid using word "content" as a noun
|
|
According to the GNU Project, using the noun "content" to describe
publications and works of authorship "adopts an attitude you might
rather avoid: it treats them as a commodity whose purpose is to fill a
box and make money. In effect, it disparages the works themselves."
From now on, we'll refer to publications as uploaded or published works.
This bug was introduced in commit
7d61e0439893a2fd946ec4d4b8e32aaaac0da322.
See: https://www.gnu.org/philosophy/words-to-avoid.en.html#Content
|
|
Instead of hardcoding the version number and duplicating version strings
in markup, have Grunt grab the version value from package.json. Adds
Gruntfile value pkgVersion.
For consideration, this will cause some issues in efforts to remove
Grunt from Pomf 3.x branch. Right now it's still considerably the best
or simplest thing we can do.
Suggested-by: Eliot Whalan <ewhal@pantsu.cat>
Suggested-by: Austin Gillmann <alucard@cuntflaps.me>
|
|
WHATWG's HTML standard vaguely implies in section "4.2.5.1 Standard
metadata names" that documents that lack a metadata generator value were
written by a user in a text editor. This is not the case for Pomf.
The next Pomf release is expected to be version 2.1.0, which was picked
here for the value.
While we are here, update copyright year to 2016 for this template.
|
|
I have a belief that Swig banners are a Grunt only thing, and they don't
really integrate very well into Swig anyway. It's kind of a hack, and a
bad one because we don't need it anymore.
By deprecating Swig banners, we should have easier time replacing
Grunt/npm with Make in a future release.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
The JavaScript-free uploader doesn't care about browser features too
much, specifically about window.FormData. That API is for JavaScript.
Because there also isn't any JavaScript to execute, this template never
gets called. It's dead HTML, so remove it.
|
|
"Gyazo Client (Puush like client)" is a horrible word monster. In the
Pomf community, it is better known as Gyazowin which refers to the
actual project and repository name.
Call it Gyazowin from now on in the tools page.
|
|
Pantsu.cat's fork of Gyazowin (aka "Gyazo Client (Puush like client)")
had moved its development to git.pantsu.cat somewhere around September
23, 2015. This link to GitHub is now dead (404 Not Found).
Replace it with the repository hosted on git.pantsu.cat, at least until
ewhal@ decides to get rid of that unmaintained repository.
Reported-by: Jaex
|
|
ShareX has moved its source code repository to GitHub. Google Code is
also shutting down, so update and point the URL to the GitHub
repository.
While we are here, update and sanitize the ShareX settings we need to
use. Also update the copyright year in header.
Reported-by: Jaex
Suggested-by: Jaex
|
|
Peter Lejeck's (peter.lejeck@) only commit in the file is a507748, which
is pretty much just the HTML layout in the file. I have changed that, a
lot.
Eric Johansson's (neku@) commits in the file covered the text itself.
This too has been replaced in commit 7d61e04, which rewrote all the
text in the page.
In other words, these two authors no longer have any meaningful content
in the file to be attributed. Much of the copyright goes to the
Pantsu.cat developers - which covers myself too.
OK luminarys@, "no complaints"
|
|
check_script.swig would hardlink to no.pantsu.cat domain for the purpose
of Catalan translations as part of a hack. Catalan translations were
removed in commit 566611c, so we can link to the nojs.html page directly
(built at compile time).
This assures that all sites using this project's code will have less to
tweak to make this project work on their site.
|
|
Clarify that the site requires JavaScript to function and what the user
should do. Telling the users only "Javascript free version" is confusing
at best, and we can do better.
For future improvement, the JavaScript-free version may be integrated on
the same page as the JavaScript uploader.
|
|
Hidden <input> values did not work as I expected for POST requests. In
GET requests, the hidden values are added as query parameters to the
URL. For POST requests, the hidden inputs are simply more form-data to
upload in the POST request (another "file").
Because of this, the HTML output parameter is never passed to upload.php
and so it returns the default response instead (JSON). The goal is to
use the HTML response.
This reverts commit d6dc103c7229cb0e2e177ce0dfc0cfb528025ca9, where the
bug was introduced.
OK ewhal@
|
|
The message and the results for why the law enforcement must be
contacted may be unclear to some. Add "they may contact us if
appropriate" to clarify the message and uphold the legal spirit, for the
lack of better words.
|
|
As seen on the ShareX project's home page, the correct spelling of the
name is with an uppercase `X`. On the tools page, it is incorrectly an
lowercase `x` (Sharex). This corrects it.
|
|
The pantsucat/pomfsecure repository has been dead for a very long time.
It is giving a "404 Not Found" error. Fix the download link to a working
Git repository.
|
|
A "valid notice" for copyright takedown is questionable and doesn't tell
much of a clue what needs to be in a takedown notice. Change it to
specify Copyright Act 1968 (Australia), which is the current copyright
legislation in Australia.
For future improvement, a copyright takedown page could be created with
more detailed instructions what needs to be included in a copyright
takedown notice.
|
|
nav.swig includes were inconsistently at either bottom of the page or
inside the jumbotron. For FAQ, the navigation was also nested
incorrectly inside the <article> element, which means the navigation
incorrectly assumed to be in-article navigation (table of contents).
The intention is to have these nav.swig (site-wide navigation) includes
outside of <article> scope. Future improvement is desired to have all
pages like other.swig and tools.swig to have <article> elements.
|
|
The <article> element is an element introduced in HTML5 for semantic
sectioning.
faq.swig is missing this semantic element, so this commit adds it.
It doesn't seem appropriate to use <article> in layout.swig, because
it's used for every page, also ones that are not articles.
Reference: http://www.w3.org/TR/html5/sections.html#the-article-element
|
|
The previous paragraph is misleading. On takedown notice, the intention
is not to disable access to files the complainer has uploaded. This
fixes the paragraph to say the intention is to disable access to
infringing content.
|
|
The banner in FAQ seems out of place and doesn't really belong to the
page. This commit removes the banners from faq.swig. The banners are
still kept on the index page.
|
|
The previous FAQ is difficult to read and doesn't actually answer to
common questions. It also lacks semantics.
Because the previous FAQ had reached a point of being next to useless
and unfixable with minor edits, it had to be rewritten.
This commit addresses the most commonly asked questions. It uses HTML5
headings for addresssing each question for proper document outline. For
future improvement, more may be added as necessary.
|
|
FAQ itself as a word as unsemantic to screen readers and not accessible.
Adding an <abbr> element improves accessibility and makes screen readers
read the title correctly.
|
|
Peter didn't actually write this piece of Swig template, and there's an
insignificant amount of templating code that could have been written by
him. We can remove him from this template's authors.
|
|
This is not the right way to do i18n. Banners are difficult and buggy
with translations, the folder structure is wrong and the result is
duplicated markup.
For the sake of maintainability, I am liberally removing this from core.
Future i18n attempts should use real gettext implementations and
possibly seperate i18n files from core as an extension.
Because Cupkle contributed the Catalan translation, this also removes
him/her from contributors.
|
|
Fixes a dead link.
|
|
bannersca.json looks for virusscans.swig, but the actual template for
this has a wrong file name lacking the "-s".
This fixes a bug introduced in 975e255.
|
|
alert-info conveys a message "this needs your attention, but it's not
super important."
alert-error conveys a message "you screwed up, please correct the error
or leave the site."
This means alert-error should only be used for errors the user has made.
Using it for an informational message about virus scans is incorrect.
|
|
This fixes style two character whitespace in pages (Swig) with one
character whitespace.
See the broken windows theory:
https://en.wikipedia.org/wiki/Broken_windows_theory
|
|
Replacing <form> action with an <input> creates an additional semantic
meaning, and it's now modifiable more easily in DOM.
|
|
This creates consistency with other Swig templates.
|
|
<br> is a presentantional element, not semantic. Use CSS instead.
|
|
This fixes a silly validation error that was introduced in last commit.
The javascript:; is reduntant anyway.
|
|
There seems to be no meaning to having this <span> element here with no
styling applied to it. It doesn't have anything to do with drag and drop
functionality either, and nothing seems to be broken after removing it.
|
|
Corrects semantics and increases accessibility.
The <a> element represents a hyperlink. A hyperlink is "a link from a
hypertext file or document to another location or file." This is not
what #upload-btn is, it's a button.
Ask yourself: "Does the element change the URL?" In our case, the upload
button does not so it is incorrect to use an <a> element here.
The idea to use <a> elements as buttons comes from years ago when you
couldn't style <button> elements in legacy browsers. Today you can, so
there's no reason to break the semantics.
Reference: http://blogs.ancestry.com/techroots/buttons-vs-anchors/
|
|
The <header> element represents a group of introductory or navigational
aids. It is semantically incorrect to use it with only one element
inside.
The <header> element was introduced in commit 87014fa08f. That commit
describes the correct usage of <header> element with multiple elements
inside <header>.
This bug was introduced in commit fd566d3d7f.
|
|
Before this commit, Catalan pages had no way to return to the Catalan
index page using the navigation.
Instead of hardcoding pantsu.cat URLs to index, use a sane "/" path.
|
