| Age | Commit message (Collapse) | Author |
|
Peter didn't actually write this piece of Swig template, and there's an
insignificant amount of templating code that could have been written by
him. We can remove him from this template's authors.
|
|
This is not the right way to do i18n. Banners are difficult and buggy
with translations, the folder structure is wrong and the result is
duplicated markup.
For the sake of maintainability, I am liberally removing this from core.
Future i18n attempts should use real gettext implementations and
possibly seperate i18n files from core as an extension.
Because Cupkle contributed the Catalan translation, this also removes
him/her from contributors.
|
|
Fixes a dead link.
|
|
bannersca.json looks for virusscans.swig, but the actual template for
this has a wrong file name lacking the "-s".
This fixes a bug introduced in 975e255.
|
|
alert-info conveys a message "this needs your attention, but it's not
super important."
alert-error conveys a message "you screwed up, please correct the error
or leave the site."
This means alert-error should only be used for errors the user has made.
Using it for an informational message about virus scans is incorrect.
|
|
This fixes style two character whitespace in pages (Swig) with one
character whitespace.
See the broken windows theory:
https://en.wikipedia.org/wiki/Broken_windows_theory
|
|
Replacing <form> action with an <input> creates an additional semantic
meaning, and it's now modifiable more easily in DOM.
|
|
This creates consistency with other Swig templates.
|
|
<br> is a presentantional element, not semantic. Use CSS instead.
|
|
This fixes a silly validation error that was introduced in last commit.
The javascript:; is reduntant anyway.
|
|
There seems to be no meaning to having this <span> element here with no
styling applied to it. It doesn't have anything to do with drag and drop
functionality either, and nothing seems to be broken after removing it.
|
|
Corrects semantics and increases accessibility.
The <a> element represents a hyperlink. A hyperlink is "a link from a
hypertext file or document to another location or file." This is not
what #upload-btn is, it's a button.
Ask yourself: "Does the element change the URL?" In our case, the upload
button does not so it is incorrect to use an <a> element here.
The idea to use <a> elements as buttons comes from years ago when you
couldn't style <button> elements in legacy browsers. Today you can, so
there's no reason to break the semantics.
Reference: http://blogs.ancestry.com/techroots/buttons-vs-anchors/
|
|
The <header> element represents a group of introductory or navigational
aids. It is semantically incorrect to use it with only one element
inside.
The <header> element was introduced in commit 87014fa08f. That commit
describes the correct usage of <header> element with multiple elements
inside <header>.
This bug was introduced in commit fd566d3d7f.
|
|
Before this commit, Catalan pages had no way to return to the Catalan
index page using the navigation.
Instead of hardcoding pantsu.cat URLs to index, use a sane "/" path.
|
|
ca.swig is confusing and difficult to find.
This commit creates consistency with other pages until someone more
knowledgeable person tells me how to sort these to /pages/ca/ with
Gruntfile.
|
|
wub@ and ewhal@ no longer have any content in this file. It's been
replaced.
|
|
|
|
|
|
|
|
|
|
Silly ewhal@, that's not how you indent pages.
Fixes a code style violation introduced in commit 87014fa08f.
|
|
|
|
|
|
|
|
|
|
|
|
Development at github has stopped and has been moved entirely over to
self hosted gogs server.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
If the shortcut value is omitted from the rel attribute, Internet
Explorer ≤ 8 ignores the declaration entirely, searches for a file
called favicon.ico in the site root, and uses that instead. In fact,
almost every browser does that when there’s no link rel="icon"
specified. Using rel="icon shortcut" won’t work in IE either, since it
doesn’t treat the rel attribute as a space-separated list.
[1] https://mathiasbynens.be/notes/rel-shortcut-icon
|