| Age | Commit message (Collapse) | Author |
|---|
|
Fixes ESLint no-unused-expressions warning.
|
|
Fixes ESLint no-cond-assign warning.
-- Sat, 26 Sep 2015 --
10:38:42 +bursey | while (node = node.parentNode) is invalid
10:38:54 +bursey | should be while (node == node.parentNode)
10:40:38 +bursey | weird actually
10:40:55 +bursey | Elements tend to be "true" in js
10:41:16 +bursey | but if the parentNode is undefined, then it's
| false
10:41:50 +bursey | thus it doesn't loop infinitely
10:43:00 +bursey | actually, use === instead of ==
|
|
Introduces client-side UPLOAD_ERR_MAX_SIZE and UPLOAD_ERR_FAILED
constants.
This reduces code duplication, which means less code smell.
|
|
There appears to be no such thing as a terrible scary bug that needs a
workaround in my Chromium 45.0.2454.85 browser to encode …. The
unobvious self-closing <div/> is also very questionable.
For what it's worth, … will encode correctly as long as you use
jQuery's .html() method – which it already did anyway.
OK ewhal@
|
|
OK ewhal@
|
|
This change may seem very subtle, but many screen readers will actually
behave differently.
Before this commit, a screenreader like JAWS may read "Grabbing URLs dot
dot dot". After this commit, JAWS may read "Grabbing URLs" and pauses
for a little longer.
Reference: http://www.deque.com/blog/dont-screen-readers-read-whats-scre
en-part-1-punctuation-typographic-symbols/
|
|
This compliments commit 7dca38c.
|
|
This cleans up a little bit of smelly code, which came from a copy-paste
job.
|
|
This is not how it appeared in the initial commit 1792788f5f, but
personally I like it and style guides allow me to adjust the whitespace
for these kind of variables.
Improves readability.
|
|
Improves readability by indenting these variables to same level.
Restores whitespace style like in initial commit 1792788f5f.
|
|
|
|
Fix bug introduced in 6c82d36307.
|
|
|
|
String concatenation is used because line terminating characters are not
allowed in the ECMAScript spec. Certain style guides such as Airbnb also
endorse using string concatenation.
|
|
Both Google and Node.js style guides prefer the use of ' over ". Much of
the rest of this code also uses singlequotes, so this brings the rest of
it to same level of consistency.
|
|
|
|
The npm style guide is bad. Don't use it! The lack of semicolons can
create very subtle bugs that are hard to debug.
This commit fixes about a hundred JSHint warnings.
|
|
|
|
This fixes another npm style guide idiom, which is "comma first".
|
|
|
|
Airbnb, Google, npm, Node.js and Idiomatic style guides suggest to use
two spaces for indentation. It seems to be the widely agreed consensus.
|
|
|
|
These commits are ShareX issues, not Pomf issues. Allowing these
commits to be in the source reduces maintainability.
This reverts commits bbcffe8d745937677352edf25e6a250ca8fd507b,
943e7e62a8ca814d47168bcebf2cc92dbce9a45a and partially
1411bce1dc13bf6fea66b5899ba29d50d5c53bb0.
|
|
|
|
|
|
|
|
|
|
- Minify HTML pages (using `grunt-contrib-htmlmin`)
- Fix minor display error (force encode of HTML entity)
|
|
|
