summaryrefslogtreecommitdiff
path: root/js/cheesesteak.js
AgeCommit message (Collapse)Author
2015-10-11Merge branch 'eslint-id-length' into fix-eslint-warnings-2Juuso Lapinlampi
Fixes ESLint id-length warnings. An exception is given to var "i", because Airbnb's style guide says this is OK. A bug is in eslint-config-airbnb, which the Airbnb style guide authors have not as of today accepted to merge to fix the bug. var "$" will be fixed later.
2015-10-11Merge branch 'refactor-cheesesteak' into fix-eslint-warnings-2Juuso Lapinlampi
Events now fire faster. Fixes ESLint func-names warnings using airbnb/legacy config.
2015-10-09Lint cheesesteak.js and cabinet.js id-length < 2Juuso Lapinlampi
Fixes ESLint id-length errors using airbnb/legacy config. Variable "i" is ignored as an exception. I've also avoided creating new errors with these changes, so this also fixes some no-unused-vars and avoids creating vars-on-top errors.
2015-10-07Fix incorrect progress/load event listenersJuuso Lapinlampi
This is a symptom of copy-paste code. A file would be uploaded, but it would return the "Something went wrong" error message without telling why. Me, ewhal@ and bursey on IRC tried had a look to see what was wrong, but none of us could catch this subtle bug. It wasn't until alchimist@ (cenci0) looked at this and found the issue. Thanks. This bug was introduced in commit 2751811.
2015-10-04Revert "Remove previously added missing brace/bracket commas"Juuso Lapinlampi
The unofficial Airbnb config (eslint-config-airbnb-es5) previously thought this to be an error and so it was removed. The official Airbnb config (airbnb/legacy) now works just like the ES6 config (airbnb). Fixes ESLint comma-dangle errors using airbnb/legacy config. This reverts commit 49d58d98f5866bb9ccc9069a16d131486f04bba2.
2015-10-04Merge branch 'eslint-undef' into fix-eslint-warnings-2Juuso Lapinlampi
2015-09-28Add missing var declaration to EventEmitterJuuso Lapinlampi
Previous commit 11e9d2d forgot to add the var declaration here. Fixes ESLint no-undef warnings using Airbnb ES5 config.
2015-09-28Add missing var declarations to undefined variablesJuuso Lapinlampi
Fixes ESLint no-undef warnings using Airbnb ES5 config.
2015-09-28Remove dead uploadstart emitter startUpload()Juuso Lapinlampi
The loadstart even is only triggered once to indicate the progress has begun (initialize the progress bar). Essentially, this is dead code for two reasons: 1. It never gets emitted because initProgressBar() gets emitted first. 2. No JavaScript file in pomf core uses the non-standard uploadstart event.
2015-09-28Name and comment addEventListener functionsJuuso Lapinlampi
Using anonymous functions with event handlers is painfully slow according to benchmarks. Anonymous functions are up to 99% slower. It is also illegal to use anonymous functions in this way according to Airbnb ES5 style guide. Fixes some ESLint func-names errors using Airbnb ES5 config. Reference: https://jsperf.com/event-handler-vs-anonymous-function/3
2015-09-28Fix assignments to function parameters in JavaScriptJuuso Lapinlampi
Fixes ESLint no-param-reassing warning.
2015-09-28Remove previously added missing brace/bracket commasJuuso Lapinlampi
Until the code has been converted to ES6 in it's entirety, let's stick to Airbnb's ES5 style guide so that ESLint won't complain. This reverts commit e6f354a.
2015-09-27cheesesteak.js: Use _this to save reference to thisJuuso Lapinlampi
Fixes JSCS safeContextKeyword warnings using Airbnb preset.
2015-09-27Remove extra quotes to follow Airbnb JavaScript styleJuuso Lapinlampi
Fixes JSCS disallowQuotedKeysInObjects warnings using Airbnb preset.
2015-09-27Add missing commas before closing bracket/curly braceJuuso Lapinlampi
This adds commas to cheesesteak.js. Something to note, the Airbnb ES5 style guide opposes a trailing comma. The latest ES6 edition endorses adding a trailing comma, explaining it leads to cleaner Git diffs. Endorse the ES6 standard, that's also the Airbnb preset in JSCS. Fixes JSCS requireTrailingComma warnings using Airbnb preset.
2015-09-27Fix cheesesteak.js comments to follow Airbnb styleJuuso Lapinlampi
Airbnb says to use /** ... */ for multiline comments and // for single line comments. Fixes JSCS requirePaddingNewLinesBeforeLineComments and validateIndentation warnings using Airbnb preset.
2015-09-27Change double quotes to single quotes in cheesesteak.jsJuuso Lapinlampi
Fixes JSCS validateQuoteMarks warnings using Airbnb preset.
2015-09-27Fix illegal trailing whitespace in JavaScriptJuuso Lapinlampi
Fixes JSCS disallowTrailingWhitespace warnings using Airbnb preset.
2015-09-27Add missing newlines after blocksJuuso Lapinlampi
Fixes JSCS requirePaddingNewLinesAfterBlocks warnings using Airbnb preset.
2015-09-27Fix irregular whitespace in cheesesteak.jsJuuso Lapinlampi
Fixes ESLint warnings about no-irregular-whitespace.
2015-09-27Fix JavaScript units[] array coding styleJuuso Lapinlampi
Reduces confusion and improves readability, despite not having yet agreed on which JavaScript style guide to use.
2015-09-23Add Expat copyright headers to JavaScript filesJuuso Lapinlampi
2015-09-20Remove commented code about Mozilla's file inputWubTheCaptain
This code doesn't seem to be in use nor important. There is no good reason why this was left in here. Because it's not been in use for so long and nobody has an issue with it, let's just remove it.
2015-09-20Simplify multiple ifs to one if with OR conditionWubTheCaptain
2015-09-20Clean up cheesesteak.js and cabinet.js for JSHintWubTheCaptain
Adds curly braces and semicolons. Also change indentation to two spaces.
2015-09-20Add JSHint headers to cabinet and cheesesteakWubTheCaptain
2014-05-06Add comma to object (Fixes uglify bug)Peter Lejeck
2014-04-29Genericize defaults function into merge utilityPeter Lejeck
We're gonna use this shortly for the data field
2013-10-31Move JS into js/, replace with uncompressedPeter Lejeck
generated by cgit v1.2.3 (git 2.25.1) at 2026-10-23 00:53:45 +0200