summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-10-22pages: Move nav.swig includes from jumbotron to bottomJuuso Lapinlampi
nav.swig includes were inconsistently at either bottom of the page or inside the jumbotron. For FAQ, the navigation was also nested incorrectly inside the <article> element, which means the navigation incorrectly assumed to be in-article navigation (table of contents). The intention is to have these nav.swig (site-wide navigation) includes outside of <article> scope. Future improvement is desired to have all pages like other.swig and tools.swig to have <article> elements.
2015-10-22FAQ: Wrap body in <article> elementJuuso Lapinlampi
The <article> element is an element introduced in HTML5 for semantic sectioning. faq.swig is missing this semantic element, so this commit adds it. It doesn't seem appropriate to use <article> in layout.swig, because it's used for every page, also ones that are not articles. Reference: http://www.w3.org/TR/html5/sections.html#the-article-element
2015-10-22FAQ: Clarify disabling access to infringing contentJuuso Lapinlampi
The previous paragraph is misleading. On takedown notice, the intention is not to disable access to files the complainer has uploaded. This fixes the paragraph to say the intention is to disable access to infringing content.
2015-10-21Remove banners include from FAQ pageJuuso Lapinlampi
The banner in FAQ seems out of place and doesn't really belong to the page. This commit removes the banners from faq.swig. The banners are still kept on the index page.
2015-10-21Rewrite the FAQ page with better text and semanticsJuuso Lapinlampi
The previous FAQ is difficult to read and doesn't actually answer to common questions. It also lacks semantics. Because the previous FAQ had reached a point of being next to useless and unfixable with minor edits, it had to be rewritten. This commit addresses the most commonly asked questions. It uses HTML5 headings for addresssing each question for proper document outline. For future improvement, more may be added as necessary.
2015-10-21Add <abbr> element to FAQ page heading level 1Juuso Lapinlampi
FAQ itself as a word as unsemantic to screen readers and not accessible. Adding an <abbr> element improves accessibility and makes screen readers read the title correctly.
2015-10-19Remove Peter Lejeck from upload_form_nojs.swig authorsJuuso Lapinlampi
Peter didn't actually write this piece of Swig template, and there's an insignificant amount of templating code that could have been written by him. We can remove him from this template's authors.
2015-10-18Add "Demo" subheading under "Features" in README.mdJuuso Lapinlampi
The link to real world example at Pantsu.cat is not semantically a feature, but its own demonstration. Adding a subheader for the example increases semantics further, and makes it easier to find.
2015-10-18Add "Features" section to README.mdJuuso Lapinlampi
The README.md lacks a features section, which is worthful for those searching for a suitable file sharing platform to host. This change lists the features and seperates "Requirements" to its own section. Worthy read: "How to Write a Readme Worth Reading" by Diana Thayer. https://orchestrate.io/blog/2014/07/16/how-to-write-a-readme-worth-reading/
2015-10-15Fix npm install build failure, remove extra commaJuuso Lapinlampi
This bug was introduced in previous commit 566611c.
2015-10-15Remove Catalan pages/translationsJuuso Lapinlampi
This is not the right way to do i18n. Banners are difficult and buggy with translations, the folder structure is wrong and the result is duplicated markup. For the sake of maintainability, I am liberally removing this from core. Future i18n attempts should use real gettext implementations and possibly seperate i18n files from core as an extension. Because Cupkle contributed the Catalan translation, this also removes him/her from contributors.
2015-10-14Tweak .alert-info color to satisfy WCAG 2.0 contrastJuuso Lapinlampi
WCAG 2.0 section 1.4.3 sets certain criteria for foreground/background color contrast ratio. The current contrast ratio is too low at 4.00, where the desired contrast ratio is at least 4.50. This commit changes the contrast ratio to the minimum required to fulfill the WCAG 2.0 section 1.4.3 criteria. Previously this was partially addressed in commit 6915a50, which neku forgot to attribute to my name. Reference: http://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html
2015-10-14Remove unused grunt-mkdir taskJuuso Lapinlampi
This does nothing as far as I see it, no dist/img/ is created. And hey, it works without it. grunt-contrib-copy can create directories for us.
2015-10-14Add img/ to Gruntfile copy taskJuuso Lapinlampi
Grunt would not copy `img/` to `dist/img/`, because the task of copying images was previously on the now-removed imagemin task. This bug was introduced in commit 90e6b7b.
2015-10-13Remove grunt-contrib-htmlmin HTML minificationJuuso Lapinlampi
The benefits of HTML minification are too small and outweighted by the benefits of not having to deal with yet another dependency in Pomf's code. `Vary: Accept-Encoding` on the server is the recommended way to approach this, also for clarity and debugging without browser consoles. We don't need this.
2015-10-13Remove grunt-contrib-imagemin image minificationJuuso Lapinlampi
Ever since liberating images in c76f70c, there's no really a need to minify images. Furthermore, the dependency update in 6ef710a changed PNG minification to be lossless, so most of the benefits were lost (because our images are already compressed in the repository). We don't need this anymore.
2015-10-13Remove all JSHint tools and headersJuuso Lapinlampi
JSHint is "deprecated" in favor of ESLint. Personally I have not used JSHint ever since switching to ESLint. Vague OK from ewhal@
2015-10-11Pretty print JSON responsesJuuso Lapinlampi
To understand and document the API, responses should be correct, accurate and human readable. Server-side compression (gzip) will compensate for the extra whitespace. OK ewhal@
2015-10-10Merge branch 'improve-readme' of wubthecaptain/pomfJuuso Lapinlampi
Adds "Contributing", and "Credits" sections. Rewrites "Configuring". Replaces "Contact" with "Getting help". OK alchimist@
2015-10-10Fix README.md grammarJuuso Lapinlampi
Thanks to alchimist@ for doing editorial review.
2015-10-09Rewrite "Configuring" section to be more confidentJuuso Lapinlampi
The previous example can create a feeling of worry in the mind of the reader. This will aim to fix that.
2015-10-09Clarify IRC usage for contribution merge requestsJuuso Lapinlampi
We use IRC for code review, so naturally merge requests also happen there.
2015-10-09Linkify git.pantsu.cat in README.mdJuuso Lapinlampi
2015-10-09Add "Contributing" section to README.mdJuuso Lapinlampi
Worthy read: "Top ten reasons why I won’t use your open source project" by Adam Stacoviak. https://changelog.com/top-ten-reasons-why-i-wont-use-your-open-source-project/
2015-10-09Replace Pomf.se HTTPS link to HTTP in README.mdJuuso Lapinlampi
It seems neku doesn't have a working HTTPS website anymore. It certainly used to.
2015-10-09Add "Credits" section to README.mdJuuso Lapinlampi
2015-10-09Replace "Contact" section with "Getting help"Juuso Lapinlampi
This also adds a mention of the IRC channel. Worthy read: "Readme Driven Development" by Tom Preston-Werner: http://tom.preston-werner.com/2010/08/23/readme-driven-development.html
2015-10-07Update gyazowin tool author contact to @4vailJuuso Lapinlampi
Fixes a dead link.
2015-09-28Merge branch 'fix-eslint-warnings' of wubthecaptain/pomfJuuso Lapinlampi
Before this merge, ESLint reported about 114 problems (76 errors, 38 warnings). This merge reduces that to about 67 problems (29 errors, 38 warnings) using Airbnb ES5 config. OK ewhal@
2015-09-28Remove previously added missing brace/bracket commasJuuso Lapinlampi
Until the code has been converted to ES6 in it's entirety, let's stick to Airbnb's ES5 style guide so that ESLint won't complain. This reverts commit e6f354a.
2015-09-28Remove extra newline padding from pomf.jsJuuso Lapinlampi
This newline was accidentally introduced in commit a17c446. Fixes ESLint warning padded-blocks using Airbnb ES5 config.
2015-09-28Add pomf.js parseInt() radix 10Juuso Lapinlampi
Fixes ESLint radix warning using Airbnb ES5 config.
2015-09-27Fix JS switch ... case indentationJuuso Lapinlampi
This is a surprising one. JSHint and JSCS do not seem to mind the previous indentation, but ESLint throws an error when using the Airbnb style guide. The style guide itself doesn't seem to mention anything about this directly. What ever it is, this one pleases all three linters. Fixes ESLint indent warnings using Airbnb ES5 config.
2015-09-27cheesesteak.js: Use _this to save reference to thisJuuso Lapinlampi
Fixes JSCS safeContextKeyword warnings using Airbnb preset.
2015-09-27Remove extra quotes to follow Airbnb JavaScript styleJuuso Lapinlampi
Fixes JSCS disallowQuotedKeysInObjects warnings using Airbnb preset.
2015-09-27Add missing commas before closing bracket/curly braceJuuso Lapinlampi
This adds commas to cheesesteak.js. Something to note, the Airbnb ES5 style guide opposes a trailing comma. The latest ES6 edition endorses adding a trailing comma, explaining it leads to cleaner Git diffs. Endorse the ES6 standard, that's also the Airbnb preset in JSCS. Fixes JSCS requireTrailingComma warnings using Airbnb preset.
2015-09-27Fix cheesesteak.js comments to follow Airbnb styleJuuso Lapinlampi
Airbnb says to use /** ... */ for multiline comments and // for single line comments. Fixes JSCS requirePaddingNewLinesBeforeLineComments and validateIndentation warnings using Airbnb preset.
2015-09-27Use individual Javascript var declarationsJuuso Lapinlampi
Thanks to ASI (Automatic Semicolon Insertion) in JavaScript, not using individual var declarations can actually cause subtle bugs. Fixes JSCS disallowMultipleVarDecl warnings using Airbnb preset. Reference: http://benalman.com/news/2012/05/multiple-var-statements-javascript/
2015-09-27Change double quotes to single quotes in cheesesteak.jsJuuso Lapinlampi
Fixes JSCS validateQuoteMarks warnings using Airbnb preset.
2015-09-27Fix illegal trailing whitespace in JavaScriptJuuso Lapinlampi
Fixes JSCS disallowTrailingWhitespace warnings using Airbnb preset.
2015-09-27Add missing newlines after blocksJuuso Lapinlampi
Fixes JSCS requirePaddingNewLinesAfterBlocks warnings using Airbnb preset.
2015-09-27Fix redeclaration of "res" variable in pomf.jsJuuso Lapinlampi
Fixes ESLint warning no-redeclare.
2015-09-27Fix irregular whitespace in cheesesteak.jsJuuso Lapinlampi
Fixes ESLint warnings about no-irregular-whitespace.
2015-09-27Remove Gruntfile cssmin task banner optionJuuso Lapinlampi
The banner option was removed in grunt-contrib-cssmin v0.11.0. This removes the dead config option.
2015-09-27Remove unused expression (hits[file.name] = 0)Juuso Lapinlampi
Fixes ESLint no-unused-expressions warning.
2015-09-27Use strict node === node.parentNode comparisonJuuso Lapinlampi
Fixes ESLint no-cond-assign warning. -- Sat, 26 Sep 2015 -- 10:38:42 +bursey | while (node = node.parentNode) is invalid 10:38:54 +bursey | should be while (node == node.parentNode) 10:40:38 +bursey | weird actually 10:40:55 +bursey | Elements tend to be "true" in js 10:41:16 +bursey | but if the parentNode is undefined, then it's | false 10:41:50 +bursey | thus it doesn't loop infinitely 10:43:00 +bursey | actually, use === instead of ==
2015-09-27Fix JavaScript units[] array coding styleJuuso Lapinlampi
Reduces confusion and improves readability, despite not having yet agreed on which JavaScript style guide to use.
2015-09-27Replace copy-pasted pomf.js errors with constantsJuuso Lapinlampi
Introduces client-side UPLOAD_ERR_MAX_SIZE and UPLOAD_ERR_FAILED constants. This reduces code duplication, which means less code smell.
2015-09-27Add Cupkle to package.json contributorsJuuso Lapinlampi
Cupkle has contributed a Catalan translation, merged to master in commit e233523.
2015-09-27Simplify contributors array in package.jsonJuuso Lapinlampi
npm allows to shorten contributors into a single string, the following format: "Author Name <me@authorname.example> (http://authorname.example)" This commit changes the array to the shortened strings.