summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-06-14Remove reverted commits from changelogEliot Whalan
2016-06-14Update dev-dependsEliot Whalan
2016-06-14Revert "Remove now-dead code for kawaii grill images"Eliot Whalan
This reverts commit 79fbcfb4a236650b2ee48569729947878e997466.
2016-06-14Revert "Remove grunt-contrib-imagemin image minification"Eliot Whalan
This reverts commit 90e6b7bdfeccff5e96f0bda23bc5c9ab7b33238a.
2016-06-14Revert "Remove grunt-contrib-htmlmin HTML minification"Eliot Whalan
This reverts commit 51d101f50785b0da88deaf4ede6031fbc7176c7a.
2016-06-14Revert "upload.php: Deprecate all named functions"Eliot Whalan
This reverts commit cae3cb012812c2d7e1995301e85c8954567a499d.
2016-06-14Revert "CHANGELOG: Update 2.1.0 up to 99fe3f0"Eliot Whalan
This reverts commit d22eba66c03ad823298dfacfaeb86754ea47427f.
2016-06-14Revert "Remove non-free kawaii images"Eliot Whalan
This reverts commit 61b37dfa1c2d40d1483505d2de2f1bb2428e99dc.
2016-06-13Update dependenciesEliot Whalan
2016-05-30Revert "CHANGELOG: Update 2.1.0 up to 647d32a2"Eliot Whalan
This reverts commit 1117f68b7a388bd53ac3f3f076c80da171d0b8a6.
2016-05-30Revert "Merge branch 'wub/deprecate-ewhal'"Eliot Whalan
This reverts commit 647d32a29978579f88baa7c06c207e6a8d6a0d3e, reversing changes made to 22063af06536671b680fa9bc84b4626192c106cc.
2016-05-29CHANGELOG: Update 2.1.0 up to 792e145Juuso Lapinlampi
Add tools page to deprecated features in Pomf 2.1.0.
2016-05-29pages: Deprecate tools pageJuuso Lapinlampi
The tools page is long-hated from a Pomf maintainer perspective. URLs are rarely long lived, tools fall unsupported quickly, every Pomf clone tries to furiously make its own edits to the tools page etc. It's awful. Let's remind that Pomf's primary scope is a file uploader, not a collection of tools. A third-party site can list the available and supported tools, and it can be a collaborated effort. At this point, the API isn't even stable to support any tools. All the API functions are deprecated at this point, and the upload end-point /upload.php is to be phased away into some other saner URI which doesn't rely on PHP to be used 20 years later. These tools very likely won't be supported later. Please don't even mention about ShareX source code and Git commit messages. You'll cry. Lastly someone may complain about a years old unsupported Pomf release that no longer gets updates, and how their tool in the tools page is wrong or broken despite the tool supporting the older API. You'll get my point: this is not a Pomf core feature, but an extension. ewhal fell off. Cc: Eliot Whalan <ewhal@pantsu.cat>
2016-05-29CHANGELOG: Update 2.1.0 up to 99fe3f0Juuso Lapinlampi
Deprecate `diverse_array()`, `generate_name()`, `refiles()` and `upload_file()` functions.
2016-05-29upload.php: Deprecate all named functionsJuuso Lapinlampi
Deprecates diverse_array(), generate_name(), refiles() and upload_file(). These pollute the global namespace and do not follow the PSR-2 naming convention. The plan is to create a new file with a new class to share this common code, leaving upload.php only with the last lines of code that it really needs to do (calling other class functions). Acked-by: Eliot Whalan <ewhal@pantsu.cat>
2016-05-29CHANGELOG: Update 2.1.0 up to 647d32a2Juuso Lapinlampi
In changed features, add "autistic neckbeard" change. In deprecated features, add: - JavaScript-free uploader; - Other services page; - HTML and text responses.
2016-05-29Merge branch 'wub/deprecate-ewhal'Juuso Lapinlampi
Deprecate (nearly) all things authored by Eliot Whalan. Misfeatures and customizations specifically used only by Pantsu.cat, and design choices where complexity and code duplication do not matter to achieve features easily are his efforts. Cue code maintenance hell. This merge includes: - pages: Bring back autistic neckbeard rant - pages: Deprecate JavaScript-free upload - pages: Deprecate other services - Response: Deprecate HTML and text responses Eliot disagrees with this merge and threatens to branch off development. No commits by ewhal@ since 2016 to today, only code reviews. Anything that extends Pomf core functionality should be a repository or a branch of its own, an extension. If later removed, HTML and text responses may be reintroduced as extensions (pomf-response-html, pomf-response-text repositories) or as different PHP files/classes once the code is stable enough to support those features in a sensible and maintainable way. The JavaScript-free uploader is a mess of duplicated Swig templates. The "other services" page is mainly only useful for Pantsu.cat. I love autistic neckbeards. Then there's this quote: ewhal4 | I've made pantsu.cat as autism friendly as possible and now you are removing it :( Preliminary, I welcome to follow ~wub/pomf.git if development branches off from here.
2016-05-29CHANGELOG: Update 2.1.0 up to 19a3645Juuso Lapinlampi
Add upload_file() temporary file unlinking (or the lack of it) to Pomf 2.1.0 changed features.
2016-05-29upload.php: Don't unlink() tempfiles in upload_file()Juuso Lapinlampi
We don't need to care about garbage collection and explicitly unlinking temporary files: PHP will handle that for us automatically. In other words, this is "dead" code. Less code the better. Updates the comment before it to reflect this. Tested on PHP 5.6.22 and PHP 7.0.7 on Debian stretch/sid GNU/Linux. Tested-by: Juuso Lapinlampi <wub@partyvan.eu> See: https://secure.php.net/manual/en/function.tmpfile.php
2016-05-29Response: Deprecate HTML and text responsesJuuso Lapinlampi
HTML and text responses were introduced by Eliot to Pomf 2.0 primarily for the JavaScript-free uploader (which is also deprecated). I can't imagine any sane tool preferring to have either of these flawed responses over JSON or CSV. They increase code complexity and duplication. Let them fall off. ewhal fell off. Cc: Eliot Whalan <ewhal@pantsu.cat>
2016-05-29pages: Deprecate other servicesJuuso Lapinlampi
The other services page was introduced in Pomf 2.0 as a customization for Pantsu.cat, pushed to master branch as a misled approach to development. There's no good reason to keep this as a Pomf core feature. ewhal fell off. Cc: Eliot Whalan <ewhal@pantsu.cat>
2016-05-29pages: Deprecate JavaScript-free uploadJuuso Lapinlampi
JavaScript-free uploading was introduced in Pomf 2.0 as a misfeature. It increases complexity of the API code base and duplicates some code. This was obviously a misled approach to Pomf development. The recommended approach to solving this issue is using the upload API with external tools. ewhal fell off. Cc: Eliot Whalan <ewhal@pantsu.cat>
2016-05-29pages: Bring back autistic neckbeard rantJuuso Lapinlampi
The return of the almost legendary autistic neckbeard rant loved or hated by everyone. Shown to noscript users. This bug was introduced in the following commits: - Rephrase check_script.swig JavaScript warning (6c3491c) - Remove unnecessary paragraphs (254760b) - Add link to JS free version (55fb54d) This also fixes a grammar issue found in the previous iteration of this feature: "autist neckbeard" -> "autistic neckbeard". ewhal fell off. Cc: Eliot Whalan <ewhal@pantsu.cat>
2016-05-29Revert "CHANGELOG: Update 2.1.0 up to a64dea5"Juuso Lapinlampi
Actually, this is not what we want to note. The change log was added to this release as a new feature, thus it is not a fix to a previous release. This reverts commit a7e0c93be2952910e454c7ad8b3ebc57d0bc902c.
2016-05-29CHANGELOG: Update 2.1.0 up to a64dea5Juuso Lapinlampi
Add recent two changelog meta fixes to Pomf 2.1.0 fixed features. These commits are: - CHANGELOG: Move "removed" before "fixed" sections (a64dea5) - CHANGELOG: Move 1.0.0+8757e9a XSS to security section (a8aff8d)
2016-05-29CHANGELOG: Move "removed" before "fixed" sectionsJuuso Lapinlampi
Per "Keep a CHANGELOG" guideline. See: http://keepachangelog.com/
2016-05-29CHANGELOG: Move 1.0.0+8757e9a XSS to security sectionJuuso Lapinlampi
Per "Keep a CHANGELOG" guideline. See: http://keepachangelog.com/
2016-05-29CHANGELOG: Update up to 890a0dcJuuso Lapinlampi
For Pomf 2.1.0, add improved abbreviation support to added features. For Pomf 2.0.3, add missing space character before file size to fixed features.
2016-05-29pages: Unabbreviate FAQ with <abbr> in indexJuuso Lapinlampi
The FAQ page already unabbreviates the FAQ abbreviation. This aids screen readers to pronounce the abbreviation correctly to increase comprehension and adds semantics. Acked-by: Eliot Whalan <ewhal@pantsu.cat>
2016-05-29Merge branch 'maint'Juuso Lapinlampi
Sync with Pomf 2.0.x maint branch. - pages: Add a non-breaking space before "MiB" Corrects a typo and adds the missing space character to index.
2016-05-29pages: Add a non-breaking space before "MiB"Juuso Lapinlampi
Fixes a typo where the unit symbol was missing a space character before it. To avoid automatic line breaks in text "128 MiB", a non-breaking space character is used instead of a regular space character. If the text doesn't fit at the end of a line it is moved in its entirety to the next line. Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
2016-05-29CHANGELOG: Update 2.0.3 up to cd2dbfcJuuso Lapinlampi
Add Japanese "baka" lang attribute fix to Pomf 2.0.3 fixed features.
2016-05-29Merge branch 'maint'Juuso Lapinlampi
Sync with Pomf 2.0.x maint branch. - pages: Add Japanese HTML lang attribute to "baka" Corrects pronunction by screen readers and improves semantics.
2016-05-29pages: Add Japanese HTML lang attribute to "baka"Juuso Lapinlampi
Corrects pronunction by screen readers and improves semantics. Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
2016-05-29CHANGELOG: Update up to 93e1720Juuso Lapinlampi
Add "Response: Return 500 Internal Server Error on error()" (commit 18f66c8) to fixed issues in Pomf 2.0.3.
2016-05-29Merge branch 'maint'Juuso Lapinlampi
Sync with Pomf 2.0.x maint branch. - Response: Return 500 Internal Server Error on error()
2016-05-29Merge branch 'wub/response/fix-http_response_code' into maintJuuso Lapinlampi
Fixes a bug where Response class `error()` function may blow up and invalid HTTP status code `42` if `PDO::ATTR_ERRMODE` is set to `PDO::ERRMODE_EXCEPTION` during PDO initialization or query. Clarifies what HTTP status codes 200 and 500 are for readability.
2016-05-29Response: Clarify what http_response_code(200); isJuuso Lapinlampi
Add a comment explaining how HTTP status code 200 means success. Cherry-picked from master 4606553f38909b483bc06674f9558ede1a9ff1f6.
2016-05-29Response: Return 500 Internal Server Error on error()Juuso Lapinlampi
Fix a bug where Response class `error()` function may blow up and return an invalid HTTP status code `42` if `PDO::ATTR_ERRMODE` is set to `PDO::ERRMODE_EXCEPTION` during PDO initialization or query. By default, it is implicitly set to `PDO::ERRMODE_SILENT`. This bug can occur when a MySQL server is running, but encounters an error post-login (e.g. table doesn't exist).
2016-05-27Merge branch 'maint'Juuso Lapinlampi
Sync with Pomf 2.0.x maint branch. - FAQ: Add Pantsu.cat copyright year 2016
2016-05-27FAQ: Add Pantsu.cat copyright year 2016Juuso Lapinlampi
These commits made some recent changes to the FAQ in year 2016: - FAQ: Change non-abuse contact to info@pantsu.cat - FAQ: Avoid using word "content" as a noun These may be covered by copyright.
2016-05-27Merge branch 'wub/use-rfc-2142-info'Juuso Lapinlampi
- FAQ: Change non-abuse contact to info@pantsu.cat - CHANGELOG: Update 2.1.0 up to 49e2fa5 The FAQ incorrectly uses contact@ as the point of contact for non-abuse communication. This mailbox name is not recognized by RFC 2142, but info@ is. Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
2016-05-27CHANGELOG: Update 2.1.0 up to 49e2fa5Juuso Lapinlampi
Add changed contact email (info@pantsu.cat) to changes in Pomf 2.1.0.
2016-05-27FAQ: Change non-abuse contact to info@pantsu.catJuuso Lapinlampi
Set a good example and use info@ for the non-abuse contact. This is an RFC 2142-ification, which I for long wanted ewhal to do but he previously did not do for some reason. contact@ is not an RFC 2142 recognized mailbox name. See: https://tools.ietf.org/html/rfc2142
2016-05-27CHANGELOG: Add 2.0.3 up to ec67dd5Juuso Lapinlampi
Create a new section for unreleased Pomf 2.0.3. Mention the fixed bug where the FAQ would incorrectly refer to uploaded/published works as "content".
2016-05-27Merge branch 'maint'Juuso Lapinlampi
Sync with Pomf 2.0.x maint branch. - FAQ: Avoid using word "content" as a noun
2016-05-27FAQ: Avoid using word "content" as a nounJuuso Lapinlampi
According to the GNU Project, using the noun "content" to describe publications and works of authorship "adopts an attitude you might rather avoid: it treats them as a commodity whose purpose is to fill a box and make money. In effect, it disparages the works themselves." From now on, we'll refer to publications as uploaded or published works. This bug was introduced in commit 7d61e0439893a2fd946ec4d4b8e32aaaac0da322. See: https://www.gnu.org/philosophy/words-to-avoid.en.html#Content
2016-05-25Merge branch 'wub/deprecate-ob_start'Juuso Lapinlampi
- upload.php: Deprecate ob_start (output buffering) - CHANGELOG: Update 2.1.0 up to f4504ac Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
2016-05-25CHANGELOG: Update 2.1.0 up to f4504acJuuso Lapinlampi
Add output buffering to 2.1.0 deprecated features.
2016-05-25upload.php: Deprecate ob_start (output buffering)Juuso Lapinlampi
None of us can find a reason why we would need to buffer our output in a PHP application. My best guess is this may be a relic from Pomf 1.0.0 or Moe panel. Unless someone finds a better reason to keep this, this feature is useless and has negligible benefit and will be removed. In respect for SemVer, deprecating this feature happens first in a minor version before removal in a next major version. Acked-by: Eliot Whalan <ewhal@pantsu.cat>