| Age | Commit message (Collapse) | Author |
|---|
|
JavaScript-free uploading was introduced in Pomf 2.0 as a misfeature. It
increases complexity of the API code base and duplicates some code.
This was obviously a misled approach to Pomf development. The
recommended approach to solving this issue is using the upload API with
external tools.
ewhal fell off.
Cc: Eliot Whalan <ewhal@pantsu.cat>
|
|
The return of the almost legendary autistic neckbeard rant loved or
hated by everyone. Shown to noscript users.
This bug was introduced in the following commits:
- Rephrase check_script.swig JavaScript warning (6c3491c)
- Remove unnecessary paragraphs (254760b)
- Add link to JS free version (55fb54d)
This also fixes a grammar issue found in the previous iteration of this
feature: "autist neckbeard" -> "autistic neckbeard".
ewhal fell off.
Cc: Eliot Whalan <ewhal@pantsu.cat>
|
|
Actually, this is not what we want to note. The change log was
added to this release as a new feature, thus it is not a fix to a
previous release.
This reverts commit a7e0c93be2952910e454c7ad8b3ebc57d0bc902c.
|
|
Add recent two changelog meta fixes to Pomf 2.1.0 fixed features. These
commits are:
- CHANGELOG: Move "removed" before "fixed" sections (a64dea5)
- CHANGELOG: Move 1.0.0+8757e9a XSS to security section (a8aff8d)
|
|
Per "Keep a CHANGELOG" guideline.
See: http://keepachangelog.com/
|
|
Per "Keep a CHANGELOG" guideline.
See: http://keepachangelog.com/
|
|
For Pomf 2.1.0, add improved abbreviation support to added features.
For Pomf 2.0.3, add missing space character before file size to fixed
features.
|
|
The FAQ page already unabbreviates the FAQ abbreviation. This aids
screen readers to pronounce the abbreviation correctly to increase
comprehension and adds semantics.
Acked-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Sync with Pomf 2.0.x maint branch.
- pages: Add a non-breaking space before "MiB"
Corrects a typo and adds the missing space character to index.
|
|
Fixes a typo where the unit symbol was missing a space character before
it.
To avoid automatic line breaks in text "128 MiB", a non-breaking space
character is used instead of a regular space character. If the text
doesn't fit at the end of a line it is moved in its entirety to the next
line.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Add Japanese "baka" lang attribute fix to Pomf 2.0.3 fixed features.
|
|
Sync with Pomf 2.0.x maint branch.
- pages: Add Japanese HTML lang attribute to "baka"
Corrects pronunction by screen readers and improves semantics.
|
|
Corrects pronunction by screen readers and improves semantics.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Add "Response: Return 500 Internal Server Error on error()" (commit
18f66c8) to fixed issues in Pomf 2.0.3.
|
|
Sync with Pomf 2.0.x maint branch.
- Response: Return 500 Internal Server Error on error()
|
|
Fixes a bug where Response class `error()` function may blow up and
invalid HTTP status code `42` if `PDO::ATTR_ERRMODE` is set to
`PDO::ERRMODE_EXCEPTION` during PDO initialization or query.
Clarifies what HTTP status codes 200 and 500 are for readability.
|
|
Add a comment explaining how HTTP status code 200 means success.
Cherry-picked from master 4606553f38909b483bc06674f9558ede1a9ff1f6.
|
|
Fix a bug where Response class `error()` function may blow up and return
an invalid HTTP status code `42` if `PDO::ATTR_ERRMODE` is set to
`PDO::ERRMODE_EXCEPTION` during PDO initialization or query. By default,
it is implicitly set to `PDO::ERRMODE_SILENT`.
This bug can occur when a MySQL server is running, but encounters an
error post-login (e.g. table doesn't exist).
|
|
Sync with Pomf 2.0.x maint branch.
- FAQ: Add Pantsu.cat copyright year 2016
|
|
These commits made some recent changes to the FAQ in year 2016:
- FAQ: Change non-abuse contact to info@pantsu.cat
- FAQ: Avoid using word "content" as a noun
These may be covered by copyright.
|
|
- FAQ: Change non-abuse contact to info@pantsu.cat
- CHANGELOG: Update 2.1.0 up to 49e2fa5
The FAQ incorrectly uses contact@ as the point of contact for non-abuse
communication. This mailbox name is not recognized by RFC 2142, but
info@ is.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Add changed contact email (info@pantsu.cat) to changes in Pomf 2.1.0.
|
|
Set a good example and use info@ for the non-abuse contact. This is an
RFC 2142-ification, which I for long wanted ewhal to do but he
previously did not do for some reason.
contact@ is not an RFC 2142 recognized mailbox name.
See: https://tools.ietf.org/html/rfc2142
|
|
Create a new section for unreleased Pomf 2.0.3.
Mention the fixed bug where the FAQ would incorrectly refer to
uploaded/published works as "content".
|
|
Sync with Pomf 2.0.x maint branch.
- FAQ: Avoid using word "content" as a noun
|
|
According to the GNU Project, using the noun "content" to describe
publications and works of authorship "adopts an attitude you might
rather avoid: it treats them as a commodity whose purpose is to fill a
box and make money. In effect, it disparages the works themselves."
From now on, we'll refer to publications as uploaded or published works.
This bug was introduced in commit
7d61e0439893a2fd946ec4d4b8e32aaaac0da322.
See: https://www.gnu.org/philosophy/words-to-avoid.en.html#Content
|
|
- upload.php: Deprecate ob_start (output buffering)
- CHANGELOG: Update 2.1.0 up to f4504ac
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Add output buffering to 2.1.0 deprecated features.
|
|
None of us can find a reason why we would need to buffer our output in a
PHP application. My best guess is this may be a relic from Pomf 1.0.0 or
Moe panel.
Unless someone finds a better reason to keep this, this feature is
useless and has negligible benefit and will be removed.
In respect for SemVer, deprecating this feature happens first in a minor
version before removal in a next major version.
Acked-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Add comments explaining how the number 500 after Exception means HTTP
status code "500 Internal Server Error". This may not be so obvious to
the reader without consulting the PHP manual.
Compliments commit 4606553f38909b483bc06674f9558ede1a9ff1f6.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Sometimes I have been slightly inconsistent and used 72 characters limit
for wrapping. The 72 character line wrap is a habit from emails. The
intention is to use 80 characters for change logs.
|
|
Add PHPDoc DocBlocks feature to 2.1.0 added features (merge commit
52a6916abe3a9fe74c4d86bee5536557c7a6fa5d).
|
|
get_sha1() was deprecated in a5314a2ff4cb503ff41da13ffd0e907f49ee4009,
so formally $sha1 was also formally deprecated but not commented.
Clarify we really want to deprecate $sha1 too.
Updates CHANGELOG.md.
|
|
- Extend and improve PHP code comments (PHPDoc)
- Add Pantsu.cat copyright year 2016 for recent change
- UploadedFile: Fix typo SHA1 to SHA-1
- Response: Clarify what http_response_code(200); is
Reviewed-by: Austin Gillmann <alucard@cuntflaps.me>
|
|
Add a comment explaining how HTTP status code 200 means success.
|
|
This typo has been around for a while. Well, not anymore.
|
|
Claiming copyright for parts of UploadedFile.class.php and
settings.inc.php as per previous change, which introduced PHPDoc
comments.
The other files where edits were made in previous commits are
non-substantial and thus most likely not under copyright.
|
|
Add file summaries, @copyright tags and other comments. Covers majority
of the PHP code base now. I have avoided being too verbose and omitted
some potential tags.
Most visibly to the user, this comments every user configurable setting
and clarifies what some of the options do.
POMF_DB_USER and POMF_DB_PASS are not rendered perfectly in
phpDocumentor version 2.8.5. This is a sacrifice I made in attempt for
not being too verbose and obvious.
Response class gets a @todo for being a god object.
|
|
Add two topics merged recently to master:
- Merge branch 'wub/refactor-upload_file'
- Replace include_once statements with require_once
Signed-off-by: Juuso Lapinlampi <wub@partyvan.eu>
Signed-off-by: Austin Gillmann <alucard@cuntflaps.me>
Reviewed-by: Austin Gillmann <alucard@cuntflaps.me>
|
|
Normally in include_once if a script does not load PHP will treat it as
such as an E_WARNING, while require_once fail the script with a
E_COMPILE_ERROR if the script does not load.
Since we require all of these scripts to properly function it
will be better to classify them as required in PHP.
Reported-by: Juuso Lapinlampi <wub@partyvan.eu>
Reviewed-by: Juuso Lapinlampi <wub@partyvan.eu>
|
|
- upload.php: Unnest upload_file() if-else expressions
- upload.php: Apply DRY to POMF_FILES_ROOT.$newname
- upload.php: Add Pantsu.cat copyright year 2016
Reviewed-by: Austin Gillmann <alucard@cuntflaps.me>
Tested-by: Austin Gillmann <alucard@cuntflaps.me>
|
|
Previous two commits in this topic branch introduced substantial
changes.
|
|
Don't repeat yourself with multiple POMF_FILES_ROOT.$newname for full
file path. Use a variable pointer $uploadFile.
Improves code readability and robustness.
|
|
As phpmd (PHP Mess Detector) linter says: "An if expression with an else
branch is never necessary." Well, at least almost never necessary.
Improves readability and resolves phpmd cleancode lint errors.
|
|
- CHANGELOG: Update 2.0.2 changelog (Bootstrap license)
- CHANGELOG: Add Pomf 2.0.2 release date (today)
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Sync with Pomf 2.0.x maint branch.
- package.json: Change version to 2.0.2
(Essentially, this merge is for git-describe(1).)
|
|
Pomf 2.0.2 has been released today and tagged v2.0.2.
|
|
This marks the Pomf 2.0.2 release.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
See: 25ec99f6f8b184dc29804358185104c800f2bcdb
|
|
Sync with Pomf 2.0.x maint branch.
- css: Add missing Bootstrap license header (Expat)
|
