| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Fix error response description
|
|
The error reason is called 'description' in the response, not 'reason'.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Credit goes to clsr for helping with this.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This reverts commit 3b4701b240f55b4e97edee7fdc13fec35a76fc5a.
|
|
|
|
|
|
|
|
This reverts commit 79fbcfb4a236650b2ee48569729947878e997466.
|
|
This reverts commit 90e6b7bdfeccff5e96f0bda23bc5c9ab7b33238a.
|
|
This reverts commit 51d101f50785b0da88deaf4ede6031fbc7176c7a.
|
|
This reverts commit cae3cb012812c2d7e1995301e85c8954567a499d.
|
|
This reverts commit d22eba66c03ad823298dfacfaeb86754ea47427f.
|
|
This reverts commit 61b37dfa1c2d40d1483505d2de2f1bb2428e99dc.
|
|
|
|
This reverts commit 1117f68b7a388bd53ac3f3f076c80da171d0b8a6.
|
|
This reverts commit 647d32a29978579f88baa7c06c207e6a8d6a0d3e, reversing
changes made to 22063af06536671b680fa9bc84b4626192c106cc.
|
|
Add tools page to deprecated features in Pomf 2.1.0.
|
|
The tools page is long-hated from a Pomf maintainer perspective. URLs
are rarely long lived, tools fall unsupported quickly, every Pomf clone
tries to furiously make its own edits to the tools page etc. It's awful.
Let's remind that Pomf's primary scope is a file uploader, not a
collection of tools. A third-party site can list the available and
supported tools, and it can be a collaborated effort.
At this point, the API isn't even stable to support any tools. All the
API functions are deprecated at this point, and the upload end-point
/upload.php is to be phased away into some other saner URI which doesn't
rely on PHP to be used 20 years later. These tools very likely won't be
supported later.
Please don't even mention about ShareX source code and Git commit
messages. You'll cry.
Lastly someone may complain about a years old unsupported Pomf release
that no longer gets updates, and how their tool in the tools page is
wrong or broken despite the tool supporting the older API. You'll get my
point: this is not a Pomf core feature, but an extension.
ewhal fell off.
Cc: Eliot Whalan <ewhal@pantsu.cat>
|
|
Deprecate `diverse_array()`, `generate_name()`, `refiles()` and
`upload_file()` functions.
|
|
Deprecates diverse_array(), generate_name(), refiles() and
upload_file(). These pollute the global namespace and do not follow the
PSR-2 naming convention.
The plan is to create a new file with a new class to share this common
code, leaving upload.php only with the last lines of code that it really
needs to do (calling other class functions).
Acked-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
In changed features, add "autistic neckbeard" change.
In deprecated features, add:
- JavaScript-free uploader;
- Other services page;
- HTML and text responses.
|
|
Deprecate (nearly) all things authored by Eliot Whalan. Misfeatures and
customizations specifically used only by Pantsu.cat, and design choices
where complexity and code duplication do not matter to achieve features
easily are his efforts. Cue code maintenance hell.
This merge includes:
- pages: Bring back autistic neckbeard rant
- pages: Deprecate JavaScript-free upload
- pages: Deprecate other services
- Response: Deprecate HTML and text responses
Eliot disagrees with this merge and threatens to branch off development.
No commits by ewhal@ since 2016 to today, only code reviews.
Anything that extends Pomf core functionality should be a repository or
a branch of its own, an extension.
If later removed, HTML and text responses may be reintroduced as
extensions (pomf-response-html, pomf-response-text repositories) or as
different PHP files/classes once the code is stable enough to support
those features in a sensible and maintainable way.
The JavaScript-free uploader is a mess of duplicated Swig templates.
The "other services" page is mainly only useful for Pantsu.cat.
I love autistic neckbeards. Then there's this quote:
ewhal4 | I've made pantsu.cat as autism friendly as possible and now
you are removing it :(
Preliminary, I welcome to follow ~wub/pomf.git if development branches
off from here.
|
|
Add upload_file() temporary file unlinking (or the lack of it) to Pomf
2.1.0 changed features.
|
|
We don't need to care about garbage collection and explicitly unlinking
temporary files: PHP will handle that for us automatically. In other
words, this is "dead" code. Less code the better.
Updates the comment before it to reflect this.
Tested on PHP 5.6.22 and PHP 7.0.7 on Debian stretch/sid GNU/Linux.
Tested-by: Juuso Lapinlampi <wub@partyvan.eu>
See: https://secure.php.net/manual/en/function.tmpfile.php
|
