summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-10-14Remove unused grunt-mkdir taskJuuso Lapinlampi
This does nothing as far as I see it, no dist/img/ is created. And hey, it works without it. grunt-contrib-copy can create directories for us.
2015-10-14Add img/ to Gruntfile copy taskJuuso Lapinlampi
Grunt would not copy `img/` to `dist/img/`, because the task of copying images was previously on the now-removed imagemin task. This bug was introduced in commit 90e6b7b.
2015-10-13Remove grunt-contrib-htmlmin HTML minificationJuuso Lapinlampi
The benefits of HTML minification are too small and outweighted by the benefits of not having to deal with yet another dependency in Pomf's code. `Vary: Accept-Encoding` on the server is the recommended way to approach this, also for clarity and debugging without browser consoles. We don't need this.
2015-10-13Remove grunt-contrib-imagemin image minificationJuuso Lapinlampi
Ever since liberating images in c76f70c, there's no really a need to minify images. Furthermore, the dependency update in 6ef710a changed PNG minification to be lossless, so most of the benefits were lost (because our images are already compressed in the repository). We don't need this anymore.
2015-10-13Remove all JSHint tools and headersJuuso Lapinlampi
JSHint is "deprecated" in favor of ESLint. Personally I have not used JSHint ever since switching to ESLint. Vague OK from ewhal@
2015-10-11Pretty print JSON responsesJuuso Lapinlampi
To understand and document the API, responses should be correct, accurate and human readable. Server-side compression (gzip) will compensate for the extra whitespace. OK ewhal@
2015-10-10Merge branch 'improve-readme' of wubthecaptain/pomfJuuso Lapinlampi
Adds "Contributing", and "Credits" sections. Rewrites "Configuring". Replaces "Contact" with "Getting help". OK alchimist@
2015-10-10Fix README.md grammarJuuso Lapinlampi
Thanks to alchimist@ for doing editorial review.
2015-10-09Rewrite "Configuring" section to be more confidentJuuso Lapinlampi
The previous example can create a feeling of worry in the mind of the reader. This will aim to fix that.
2015-10-09Clarify IRC usage for contribution merge requestsJuuso Lapinlampi
We use IRC for code review, so naturally merge requests also happen there.
2015-10-09Linkify git.pantsu.cat in README.mdJuuso Lapinlampi
2015-10-09Add "Contributing" section to README.mdJuuso Lapinlampi
Worthy read: "Top ten reasons why I won’t use your open source project" by Adam Stacoviak. https://changelog.com/top-ten-reasons-why-i-wont-use-your-open-source-project/
2015-10-09Replace Pomf.se HTTPS link to HTTP in README.mdJuuso Lapinlampi
It seems neku doesn't have a working HTTPS website anymore. It certainly used to.
2015-10-09Add "Credits" section to README.mdJuuso Lapinlampi
2015-10-09Replace "Contact" section with "Getting help"Juuso Lapinlampi
This also adds a mention of the IRC channel. Worthy read: "Readme Driven Development" by Tom Preston-Werner: http://tom.preston-werner.com/2010/08/23/readme-driven-development.html
2015-10-07Update gyazowin tool author contact to @4vailJuuso Lapinlampi
Fixes a dead link.
2015-09-28Merge branch 'fix-eslint-warnings' of wubthecaptain/pomfJuuso Lapinlampi
Before this merge, ESLint reported about 114 problems (76 errors, 38 warnings). This merge reduces that to about 67 problems (29 errors, 38 warnings) using Airbnb ES5 config. OK ewhal@
2015-09-28Remove previously added missing brace/bracket commasJuuso Lapinlampi
Until the code has been converted to ES6 in it's entirety, let's stick to Airbnb's ES5 style guide so that ESLint won't complain. This reverts commit e6f354a.
2015-09-28Remove extra newline padding from pomf.jsJuuso Lapinlampi
This newline was accidentally introduced in commit a17c446. Fixes ESLint warning padded-blocks using Airbnb ES5 config.
2015-09-28Add pomf.js parseInt() radix 10Juuso Lapinlampi
Fixes ESLint radix warning using Airbnb ES5 config.
2015-09-27Fix JS switch ... case indentationJuuso Lapinlampi
This is a surprising one. JSHint and JSCS do not seem to mind the previous indentation, but ESLint throws an error when using the Airbnb style guide. The style guide itself doesn't seem to mention anything about this directly. What ever it is, this one pleases all three linters. Fixes ESLint indent warnings using Airbnb ES5 config.
2015-09-27cheesesteak.js: Use _this to save reference to thisJuuso Lapinlampi
Fixes JSCS safeContextKeyword warnings using Airbnb preset.
2015-09-27Remove extra quotes to follow Airbnb JavaScript styleJuuso Lapinlampi
Fixes JSCS disallowQuotedKeysInObjects warnings using Airbnb preset.
2015-09-27Add missing commas before closing bracket/curly braceJuuso Lapinlampi
This adds commas to cheesesteak.js. Something to note, the Airbnb ES5 style guide opposes a trailing comma. The latest ES6 edition endorses adding a trailing comma, explaining it leads to cleaner Git diffs. Endorse the ES6 standard, that's also the Airbnb preset in JSCS. Fixes JSCS requireTrailingComma warnings using Airbnb preset.
2015-09-27Fix cheesesteak.js comments to follow Airbnb styleJuuso Lapinlampi
Airbnb says to use /** ... */ for multiline comments and // for single line comments. Fixes JSCS requirePaddingNewLinesBeforeLineComments and validateIndentation warnings using Airbnb preset.
2015-09-27Use individual Javascript var declarationsJuuso Lapinlampi
Thanks to ASI (Automatic Semicolon Insertion) in JavaScript, not using individual var declarations can actually cause subtle bugs. Fixes JSCS disallowMultipleVarDecl warnings using Airbnb preset. Reference: http://benalman.com/news/2012/05/multiple-var-statements-javascript/
2015-09-27Change double quotes to single quotes in cheesesteak.jsJuuso Lapinlampi
Fixes JSCS validateQuoteMarks warnings using Airbnb preset.
2015-09-27Fix illegal trailing whitespace in JavaScriptJuuso Lapinlampi
Fixes JSCS disallowTrailingWhitespace warnings using Airbnb preset.
2015-09-27Add missing newlines after blocksJuuso Lapinlampi
Fixes JSCS requirePaddingNewLinesAfterBlocks warnings using Airbnb preset.
2015-09-27Fix redeclaration of "res" variable in pomf.jsJuuso Lapinlampi
Fixes ESLint warning no-redeclare.
2015-09-27Fix irregular whitespace in cheesesteak.jsJuuso Lapinlampi
Fixes ESLint warnings about no-irregular-whitespace.
2015-09-27Remove Gruntfile cssmin task banner optionJuuso Lapinlampi
The banner option was removed in grunt-contrib-cssmin v0.11.0. This removes the dead config option.
2015-09-27Remove unused expression (hits[file.name] = 0)Juuso Lapinlampi
Fixes ESLint no-unused-expressions warning.
2015-09-27Use strict node === node.parentNode comparisonJuuso Lapinlampi
Fixes ESLint no-cond-assign warning. -- Sat, 26 Sep 2015 -- 10:38:42 +bursey | while (node = node.parentNode) is invalid 10:38:54 +bursey | should be while (node == node.parentNode) 10:40:38 +bursey | weird actually 10:40:55 +bursey | Elements tend to be "true" in js 10:41:16 +bursey | but if the parentNode is undefined, then it's | false 10:41:50 +bursey | thus it doesn't loop infinitely 10:43:00 +bursey | actually, use === instead of ==
2015-09-27Fix JavaScript units[] array coding styleJuuso Lapinlampi
Reduces confusion and improves readability, despite not having yet agreed on which JavaScript style guide to use.
2015-09-27Replace copy-pasted pomf.js errors with constantsJuuso Lapinlampi
Introduces client-side UPLOAD_ERR_MAX_SIZE and UPLOAD_ERR_FAILED constants. This reduces code duplication, which means less code smell.
2015-09-27Add Cupkle to package.json contributorsJuuso Lapinlampi
Cupkle has contributed a Catalan translation, merged to master in commit e233523.
2015-09-27Simplify contributors array in package.jsonJuuso Lapinlampi
npm allows to shorten contributors into a single string, the following format: "Author Name <me@authorname.example> (http://authorname.example)" This commit changes the array to the shortened strings.
2015-09-27Remove misleading comment and simplify pomf.js case 413Juuso Lapinlampi
There appears to be no such thing as a terrible scary bug that needs a workaround in my Chromium 45.0.2454.85 browser to encode &hellip;. The unobvious self-closing <div/> is also very questionable. For what it's worth, &hellip; will encode correctly as long as you use jQuery's .html() method – which it already did anyway. OK ewhal@
2015-09-27Merge branch 'remove-moe-code-in-core' of WubTheCaptain/pomfJuuso Lapinlampi
OK ewhal@
2015-09-27Remove session_start(); from upload.phpJuuso Lapinlampi
Moe panel uses PHP sessions to keep the user logged in. We don't need it anymore, it's not required for core functionality.
2015-09-27Merge branch 'grabbing-urls-hellip' of WubTheCaptain/pomfJuuso Lapinlampi
OK ewhal@
2015-09-27Merge branch 'php-strict-comparison'Juuso Lapinlampi
OK ewhal@
2015-09-27Merge branch 'totalName' of WubTheCaptain/pomfJuuso Lapinlampi
OK ewhal@
2015-09-27Fix README.md grammar "e.g.,"Juuso Lapinlampi
A punctuation mark always precedes e.g. In American English a comma should follow e.g. The list of examples following e.g. should not be exhaustive. Reference: https://en.wiktionary.org/wiki/e.g.
2015-09-27Change README.md example domain to a.pomf.exampleJuuso Lapinlampi
.example is a reserved domain name intended to be used for documentation, defined in RFC 2606. The purpose is to reduce the likelihood of conflict and confusion. OK ewhal@
2015-09-27Add Markdown inline code blocks to README.md site/PHPJuuso Lapinlampi
Ciro Santilli's Markdown Style Guide advises to mark these as code.
2015-09-27Fix README.md grammar "an attacker"Juuso Lapinlampi
English nouns begin with an indefinite article "a" or "an". Usually "a" is used when the word that follows starts with a consontant, and "an" is used when the word that follows starts with a vowel. The word "attacker" starts with a vowel and has no different pronunciation of the first letter, so the correct indefinite article to use is "an". The correct way to pronounce it is "an attacker". This fixes an error introduced in commit db66648.
2015-09-27Fix typography on "Grabbing URLs..." with &hellip;Juuso Lapinlampi
This change may seem very subtle, but many screen readers will actually behave differently. Before this commit, a screenreader like JAWS may read "Grabbing URLs dot dot dot". After this commit, JAWS may read "Grabbing URLs" and pauses for a little longer. Reference: http://www.deque.com/blog/dont-screen-readers-read-whats-scre en-part-1-punctuation-typographic-symbols/
2015-09-27Add Pantsu.cat copyright to js/pomf.jsJuuso Lapinlampi
This compliments commit 7dca38c.