| Age | Commit message (Collapse) | Author |
|
To understand and document the API, responses should be correct,
accurate and human readable. Server-side compression (gzip) will
compensate for the extra whitespace.
OK ewhal@
|
|
Adds "Contributing", and "Credits" sections. Rewrites "Configuring".
Replaces "Contact" with "Getting help".
OK alchimist@
|
|
Thanks to alchimist@ for doing editorial review.
|
|
The previous example can create a feeling of worry in the mind of the
reader. This will aim to fix that.
|
|
We use IRC for code review, so naturally merge requests also happen
there.
|
|
|
|
Worthy read: "Top ten reasons why I won’t use your open source project"
by Adam Stacoviak.
https://changelog.com/top-ten-reasons-why-i-wont-use-your-open-source-project/
|
|
It seems neku doesn't have a working HTTPS website anymore. It certainly
used to.
|
|
|
|
This also adds a mention of the IRC channel.
Worthy read: "Readme Driven Development" by Tom Preston-Werner:
http://tom.preston-werner.com/2010/08/23/readme-driven-development.html
|
|
Fixes a dead link.
|
|
Before this merge, ESLint reported about 114 problems (76 errors, 38
warnings). This merge reduces that to about 67 problems (29 errors, 38
warnings) using Airbnb ES5 config.
OK ewhal@
|
|
Until the code has been converted to ES6 in it's entirety, let's stick
to Airbnb's ES5 style guide so that ESLint won't complain.
This reverts commit e6f354a.
|
|
This newline was accidentally introduced in commit a17c446.
Fixes ESLint warning padded-blocks using Airbnb ES5 config.
|
|
Fixes ESLint radix warning using Airbnb ES5 config.
|
|
This is a surprising one. JSHint and JSCS do not seem to mind the
previous indentation, but ESLint throws an error when using the Airbnb
style guide. The style guide itself doesn't seem to mention anything
about this directly.
What ever it is, this one pleases all three linters.
Fixes ESLint indent warnings using Airbnb ES5 config.
|
|
Fixes JSCS safeContextKeyword warnings using Airbnb preset.
|
|
Fixes JSCS disallowQuotedKeysInObjects warnings using Airbnb preset.
|
|
This adds commas to cheesesteak.js.
Something to note, the Airbnb ES5 style guide opposes a trailing comma.
The latest ES6 edition endorses adding a trailing comma, explaining it
leads to cleaner Git diffs. Endorse the ES6 standard, that's also the
Airbnb preset in JSCS.
Fixes JSCS requireTrailingComma warnings using Airbnb preset.
|
|
Airbnb says to use /** ... */ for multiline comments and // for single
line comments.
Fixes JSCS requirePaddingNewLinesBeforeLineComments and
validateIndentation warnings using Airbnb preset.
|
|
Thanks to ASI (Automatic Semicolon Insertion) in JavaScript, not using
individual var declarations can actually cause subtle bugs.
Fixes JSCS disallowMultipleVarDecl warnings using Airbnb preset.
Reference:
http://benalman.com/news/2012/05/multiple-var-statements-javascript/
|
|
Fixes JSCS validateQuoteMarks warnings using Airbnb preset.
|
|
Fixes JSCS disallowTrailingWhitespace warnings using Airbnb preset.
|
|
Fixes JSCS requirePaddingNewLinesAfterBlocks warnings using Airbnb
preset.
|
|
Fixes ESLint warning no-redeclare.
|
|
Fixes ESLint warnings about no-irregular-whitespace.
|
|
The banner option was removed in grunt-contrib-cssmin v0.11.0. This
removes the dead config option.
|
|
Fixes ESLint no-unused-expressions warning.
|
|
Fixes ESLint no-cond-assign warning.
-- Sat, 26 Sep 2015 --
10:38:42 +bursey | while (node = node.parentNode) is invalid
10:38:54 +bursey | should be while (node == node.parentNode)
10:40:38 +bursey | weird actually
10:40:55 +bursey | Elements tend to be "true" in js
10:41:16 +bursey | but if the parentNode is undefined, then it's
| false
10:41:50 +bursey | thus it doesn't loop infinitely
10:43:00 +bursey | actually, use === instead of ==
|
|
Reduces confusion and improves readability, despite not having yet
agreed on which JavaScript style guide to use.
|
|
Introduces client-side UPLOAD_ERR_MAX_SIZE and UPLOAD_ERR_FAILED
constants.
This reduces code duplication, which means less code smell.
|
|
Cupkle has contributed a Catalan translation, merged to master in commit
e233523.
|
|
npm allows to shorten contributors into a single string, the following
format:
"Author Name <me@authorname.example> (http://authorname.example)"
This commit changes the array to the shortened strings.
|
|
There appears to be no such thing as a terrible scary bug that needs a
workaround in my Chromium 45.0.2454.85 browser to encode …. The
unobvious self-closing <div/> is also very questionable.
For what it's worth, … will encode correctly as long as you use
jQuery's .html() method – which it already did anyway.
OK ewhal@
|
|
OK ewhal@
|
|
Moe panel uses PHP sessions to keep the user logged in. We don't need it
anymore, it's not required for core functionality.
|
|
OK ewhal@
|
|
OK ewhal@
|
|
OK ewhal@
|
|
A punctuation mark always precedes e.g. In American English a comma
should follow e.g. The list of examples following e.g. should not be
exhaustive.
Reference: https://en.wiktionary.org/wiki/e.g.
|
|
.example is a reserved domain name intended to be used for
documentation, defined in RFC 2606. The purpose is to reduce the
likelihood of conflict and confusion.
OK ewhal@
|
|
Ciro Santilli's Markdown Style Guide advises to mark these as code.
|
|
English nouns begin with an indefinite article "a" or "an". Usually "a"
is used when the word that follows starts with a consontant, and "an"
is used when the word that follows starts with a vowel.
The word "attacker" starts with a vowel and has no different
pronunciation of the first letter, so the correct indefinite article to
use is "an". The correct way to pronounce it is "an attacker".
This fixes an error introduced in commit db66648.
|
|
This change may seem very subtle, but many screen readers will actually
behave differently.
Before this commit, a screenreader like JAWS may read "Grabbing URLs dot
dot dot". After this commit, JAWS may read "Grabbing URLs" and pauses
for a little longer.
Reference: http://www.deque.com/blog/dont-screen-readers-read-whats-scre
en-part-1-punctuation-typographic-symbols/
|
|
This compliments commit 7dca38c.
|
|
bannersca.json looks for virusscans.swig, but the actual template for
this has a wrong file name lacking the "-s".
This fixes a bug introduced in 975e255.
|
|
alert-info conveys a message "this needs your attention, but it's not
super important."
alert-error conveys a message "you screwed up, please correct the error
or leave the site."
This means alert-error should only be used for errors the user has made.
Using it for an informational message about virus scans is incorrect.
|
|
This cleans up a little bit of smelly code, which came from a copy-paste
job.
|
|
This fixes style two character whitespace in pages (Swig) with one
character whitespace.
See the broken windows theory:
https://en.wikipedia.org/wiki/Broken_windows_theory
|
|
Replacing <form> action with an <input> creates an additional semantic
meaning, and it's now modifiable more easily in DOM.
|