summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-09-28Fix unexpected use of undefined with Boolean()Juuso Lapinlampi
Airbnb style guide recommends checking booleans this way or using (!!window.FormData). The latter is more confusing for many. While !! is indeed 0.2% faster than Boolean(), it's called micro-optimization. There is no noticeable difference to the user in our use scenario and I prefer more readable code any day. Fixes ESLint no-undefined warning using Airbnb ES5 config. Reference: https://jsperf.com/boolean-conversion-speed
2015-09-28Remove dead uploadstart emitter startUpload()Juuso Lapinlampi
The loadstart even is only triggered once to indicate the progress has begun (initialize the progress bar). Essentially, this is dead code for two reasons: 1. It never gets emitted because initProgressBar() gets emitted first. 2. No JavaScript file in pomf core uses the non-standard uploadstart event.
2015-09-28Name and comment addEventListener functionsJuuso Lapinlampi
Using anonymous functions with event handlers is painfully slow according to benchmarks. Anonymous functions are up to 99% slower. It is also illegal to use anonymous functions in this way according to Airbnb ES5 style guide. Fixes some ESLint func-names errors using Airbnb ES5 config. Reference: https://jsperf.com/event-handler-vs-anonymous-function/3
2015-09-28Fix assignments to function parameters in JavaScriptJuuso Lapinlampi
Fixes ESLint no-param-reassing warning.
2015-09-28Prefix cheesesteak.js jQuery object variables with a $Juuso Lapinlampi
This fixes Airbnb ES5 style guide violations.
2015-09-28Merge branch 'fix-eslint-warnings' of wubthecaptain/pomfJuuso Lapinlampi
Before this merge, ESLint reported about 114 problems (76 errors, 38 warnings). This merge reduces that to about 67 problems (29 errors, 38 warnings) using Airbnb ES5 config. OK ewhal@
2015-09-28Remove previously added missing brace/bracket commasJuuso Lapinlampi
Until the code has been converted to ES6 in it's entirety, let's stick to Airbnb's ES5 style guide so that ESLint won't complain. This reverts commit e6f354a.
2015-09-28Remove extra newline padding from pomf.jsJuuso Lapinlampi
This newline was accidentally introduced in commit a17c446. Fixes ESLint warning padded-blocks using Airbnb ES5 config.
2015-09-28Add pomf.js parseInt() radix 10Juuso Lapinlampi
Fixes ESLint radix warning using Airbnb ES5 config.
2015-09-27Prefix jQuery object variables with a $Juuso Lapinlampi
While JSCS and ESLint do not detect this yet as of today, my eyes do. The Airbnb style guide wants to do this. This commit doesn't prefix cabinet.js, but the next commit will while addressing another issue.
2015-09-27Fix JS switch ... case indentationJuuso Lapinlampi
This is a surprising one. JSHint and JSCS do not seem to mind the previous indentation, but ESLint throws an error when using the Airbnb style guide. The style guide itself doesn't seem to mention anything about this directly. What ever it is, this one pleases all three linters. Fixes ESLint indent warnings using Airbnb ES5 config.
2015-09-27cheesesteak.js: Use _this to save reference to thisJuuso Lapinlampi
Fixes JSCS safeContextKeyword warnings using Airbnb preset.
2015-09-27Remove extra quotes to follow Airbnb JavaScript styleJuuso Lapinlampi
Fixes JSCS disallowQuotedKeysInObjects warnings using Airbnb preset.
2015-09-27Add missing commas before closing bracket/curly braceJuuso Lapinlampi
This adds commas to cheesesteak.js. Something to note, the Airbnb ES5 style guide opposes a trailing comma. The latest ES6 edition endorses adding a trailing comma, explaining it leads to cleaner Git diffs. Endorse the ES6 standard, that's also the Airbnb preset in JSCS. Fixes JSCS requireTrailingComma warnings using Airbnb preset.
2015-09-27Fix cheesesteak.js comments to follow Airbnb styleJuuso Lapinlampi
Airbnb says to use /** ... */ for multiline comments and // for single line comments. Fixes JSCS requirePaddingNewLinesBeforeLineComments and validateIndentation warnings using Airbnb preset.
2015-09-27Use individual Javascript var declarationsJuuso Lapinlampi
Thanks to ASI (Automatic Semicolon Insertion) in JavaScript, not using individual var declarations can actually cause subtle bugs. Fixes JSCS disallowMultipleVarDecl warnings using Airbnb preset. Reference: http://benalman.com/news/2012/05/multiple-var-statements-javascript/
2015-09-27Change double quotes to single quotes in cheesesteak.jsJuuso Lapinlampi
Fixes JSCS validateQuoteMarks warnings using Airbnb preset.
2015-09-27Fix illegal trailing whitespace in JavaScriptJuuso Lapinlampi
Fixes JSCS disallowTrailingWhitespace warnings using Airbnb preset.
2015-09-27Add missing newlines after blocksJuuso Lapinlampi
Fixes JSCS requirePaddingNewLinesAfterBlocks warnings using Airbnb preset.
2015-09-27Fix redeclaration of "res" variable in pomf.jsJuuso Lapinlampi
Fixes ESLint warning no-redeclare.
2015-09-27Fix irregular whitespace in cheesesteak.jsJuuso Lapinlampi
Fixes ESLint warnings about no-irregular-whitespace.
2015-09-27Remove Gruntfile cssmin task banner optionJuuso Lapinlampi
The banner option was removed in grunt-contrib-cssmin v0.11.0. This removes the dead config option.
2015-09-27Remove unused expression (hits[file.name] = 0)Juuso Lapinlampi
Fixes ESLint no-unused-expressions warning.
2015-09-27Use strict node === node.parentNode comparisonJuuso Lapinlampi
Fixes ESLint no-cond-assign warning. -- Sat, 26 Sep 2015 -- 10:38:42 +bursey | while (node = node.parentNode) is invalid 10:38:54 +bursey | should be while (node == node.parentNode) 10:40:38 +bursey | weird actually 10:40:55 +bursey | Elements tend to be "true" in js 10:41:16 +bursey | but if the parentNode is undefined, then it's | false 10:41:50 +bursey | thus it doesn't loop infinitely 10:43:00 +bursey | actually, use === instead of ==
2015-09-27Fix JavaScript units[] array coding styleJuuso Lapinlampi
Reduces confusion and improves readability, despite not having yet agreed on which JavaScript style guide to use.
2015-09-27Replace copy-pasted pomf.js errors with constantsJuuso Lapinlampi
Introduces client-side UPLOAD_ERR_MAX_SIZE and UPLOAD_ERR_FAILED constants. This reduces code duplication, which means less code smell.
2015-09-27Add Cupkle to package.json contributorsJuuso Lapinlampi
Cupkle has contributed a Catalan translation, merged to master in commit e233523.
2015-09-27Simplify contributors array in package.jsonJuuso Lapinlampi
npm allows to shorten contributors into a single string, the following format: "Author Name <me@authorname.example> (http://authorname.example)" This commit changes the array to the shortened strings.
2015-09-27Remove misleading comment and simplify pomf.js case 413Juuso Lapinlampi
There appears to be no such thing as a terrible scary bug that needs a workaround in my Chromium 45.0.2454.85 browser to encode &hellip;. The unobvious self-closing <div/> is also very questionable. For what it's worth, &hellip; will encode correctly as long as you use jQuery's .html() method – which it already did anyway. OK ewhal@
2015-09-27Merge branch 'remove-moe-code-in-core' of WubTheCaptain/pomfJuuso Lapinlampi
OK ewhal@
2015-09-27Remove session_start(); from upload.phpJuuso Lapinlampi
Moe panel uses PHP sessions to keep the user logged in. We don't need it anymore, it's not required for core functionality.
2015-09-27Merge branch 'grabbing-urls-hellip' of WubTheCaptain/pomfJuuso Lapinlampi
OK ewhal@
2015-09-27Merge branch 'php-strict-comparison'Juuso Lapinlampi
OK ewhal@
2015-09-27Merge branch 'totalName' of WubTheCaptain/pomfJuuso Lapinlampi
OK ewhal@
2015-09-27Fix README.md grammar "e.g.,"Juuso Lapinlampi
A punctuation mark always precedes e.g. In American English a comma should follow e.g. The list of examples following e.g. should not be exhaustive. Reference: https://en.wiktionary.org/wiki/e.g.
2015-09-27Change README.md example domain to a.pomf.exampleJuuso Lapinlampi
.example is a reserved domain name intended to be used for documentation, defined in RFC 2606. The purpose is to reduce the likelihood of conflict and confusion. OK ewhal@
2015-09-27Add Markdown inline code blocks to README.md site/PHPJuuso Lapinlampi
Ciro Santilli's Markdown Style Guide advises to mark these as code.
2015-09-27Fix README.md grammar "an attacker"Juuso Lapinlampi
English nouns begin with an indefinite article "a" or "an". Usually "a" is used when the word that follows starts with a consontant, and "an" is used when the word that follows starts with a vowel. The word "attacker" starts with a vowel and has no different pronunciation of the first letter, so the correct indefinite article to use is "an". The correct way to pronounce it is "an attacker". This fixes an error introduced in commit db66648.
2015-09-27Fix typography on "Grabbing URLs..." with &hellip;Juuso Lapinlampi
This change may seem very subtle, but many screen readers will actually behave differently. Before this commit, a screenreader like JAWS may read "Grabbing URLs dot dot dot". After this commit, JAWS may read "Grabbing URLs" and pauses for a little longer. Reference: http://www.deque.com/blog/dont-screen-readers-read-whats-scre en-part-1-punctuation-typographic-symbols/
2015-09-27Add Pantsu.cat copyright to js/pomf.jsJuuso Lapinlampi
This compliments commit 7dca38c.
2015-09-26Rename Catalan virus scans banner as virusscans.swigJuuso Lapinlampi
bannersca.json looks for virusscans.swig, but the actual template for this has a wrong file name lacking the "-s". This fixes a bug introduced in 975e255.
2015-09-26Change virus scan banner class to alert-infoJuuso Lapinlampi
alert-info conveys a message "this needs your attention, but it's not super important." alert-error conveys a message "you screwed up, please correct the error or leave the site." This means alert-error should only be used for errors the user has made. Using it for an informational message about virus scans is incorrect.
2015-09-26Use cached totalName instead of $('.file-name', totalRow)Juuso Lapinlampi
This cleans up a little bit of smelly code, which came from a copy-paste job.
2015-09-26Remove extra two character whitespace between wordsJuuso Lapinlampi
This fixes style two character whitespace in pages (Swig) with one character whitespace. See the broken windows theory: https://en.wikipedia.org/wiki/Broken_windows_theory
2015-09-26Use <input type="hidden"> in upload_form_nojs.swigJuuso Lapinlampi
Replacing <form> action with an <input> creates an additional semantic meaning, and it's now modifiable more easily in DOM.
2015-09-26Indent upload_form_nojs.swig from spaces to tabsJuuso Lapinlampi
This creates consistency with other Swig templates.
2015-09-26Remove <br> element from upload_form_nojs.swigJuuso Lapinlampi
<br> is a presentantional element, not semantic. Use CSS instead.
2015-09-26Remove non-valid href element from #upload-btnJuuso Lapinlampi
This fixes a silly validation error that was introduced in last commit. The javascript:; is reduntant anyway.
2015-09-26Indent Gruntfile uglify task banner to two spacesJuuso Lapinlampi
Improves readability and consistency.
2015-09-26Remove reduntant <span> element in #upload-btnJuuso Lapinlampi
There seems to be no meaning to having this <span> element here with no styling applied to it. It doesn't have anything to do with drag and drop functionality either, and nothing seems to be broken after removing it.
generated by cgit v1.2.3 (git 2.25.1) at 2026-10-22 20:43:45 +0200