| Age | Commit message (Collapse) | Author |
|---|
|
Instead of hardcoding the version number and duplicating version strings
in markup, have Grunt grab the version value from package.json. Adds
Gruntfile value pkgVersion.
For consideration, this will cause some issues in efforts to remove
Grunt from Pomf 3.x branch. Right now it's still considerably the best
or simplest thing we can do.
Suggested-by: Eliot Whalan <ewhal@pantsu.cat>
Suggested-by: Austin Gillmann <alucard@cuntflaps.me>
|
|
WHATWG's HTML standard vaguely implies in section "4.2.5.1 Standard
metadata names" that documents that lack a metadata generator value were
written by a user in a text editor. This is not the case for Pomf.
The next Pomf release is expected to be version 2.1.0, which was picked
here for the value.
While we are here, update copyright year to 2016 for this template.
|
|
I have a belief that Swig banners are a Grunt only thing, and they don't
really integrate very well into Swig anyway. It's kind of a hack, and a
bad one because we don't need it anymore.
By deprecating Swig banners, we should have easier time replacing
Grunt/npm with Make in a future release.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Add CHANGELOG.md with human readable change logs for 1.0.0..HEAD. The
change log adheres to "Keep a CHANGELOG" [1] convention, not GNU
standards.
Release notes for 1.0.0 and 1.0.0+8757e9a are stubs.
[1]: http://keepachangelog.com/
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Pomf 2.1.0 has not been released yet, but we're keeping track of changes
anyway as per "Keep a CHANGELOG" [1] guidance. Thus, the date is marked
"Unreleased".
More changes will be tracked as development will continue and progress
forward.
[1]: http://keepachangelog.com/
|
|
|
|
|
|
Includes changelogs for 1.0.0+8757e9a..v2.0.0. The format used is "Keep
a CHANGELOG" [1] as a result of conversation with Eliot.
For future improvement, changelogs for newer releases (e.g. v2.0.1 and
unreleased v2.1.0) should be written.
[1]: http://keepachangelog.com/
Acked-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
This marks the Pomf 2.0.1 release.
Sorry again that the changelogs didn't make it to this release - we're
working on it. Hopefully.
|
|
Sync with maint branch to merge two patches to master.
|
|
- Add missing newline to Response.class.php
- Fix undeclared vars in html_success() and text_success()
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
Reviewed-by: clsr <clsr@clsr.net>
|
|
As explained by clsr:
> <clsr> With default PHP settings, that'd print a warning, then treat
> $result as if it was an empty string before appending.
This bug was introduced in commit
a92961f24072bc4c3881bf0e2f609562f3703471 and
1411bce1dc13bf6fea66b5899ba29d50d5c53bb0.
Reported-by: clsr <clsr@clsr.net>
Suggested-by: clsr <clsr@clsr.net>
|
|
Right before text_error(), there was a missing newline. This bug was
introduced in commit a92961f24072bc4c3881bf0e2f609562f3703471.
|
|
Sanity merge. Instead of merging feature branches to both maint and
master, we should merge them to maint and then merge maint to master as
per gitworkflows(7).
This makes sure the branches are in sync and there will be no issues
later on. It also simplifies git-log(1) with --graph.
Fixes disperancy with `git log master..maint`, which should not list any
commits. My fault.
|
|
Remove page specific style rules. These are unused relics from before
2.0.0 release.
This merge compliments 7743e0ec4e1c71e7cc0e0df6203e02d221c82721, which
was merged too early.
|
|
Remove page specific style rules. These are unused relics from before
2.0.0 release.
This merge compliments 7743e0ec4e1c71e7cc0e0df6203e02d221c82721, which
was merged too early.
|
|
The tools page has only had alive and maintained tools on it since Pomf
2.0.0. Ded and old tools have been removed in commit
627937d0fa632a677f278af467886915c0a36f35.
It is anticipated that these style rules will be never used again. If we
did, we can add them back later: "you aren't gonna need it" (YAGNI). If
it's dead, you should probably remove the tool from the tools page
instead of beating a dead horse.
[wub@partyvan.eu: Modified Git commit message, as discussed]
Signed-off-by: Juuso Lapinlampi <wub@partyvan.eu>
|
|
Remove inclusion of a dead template in JavaScript-free uploader.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Remove inclusion of a dead template in JavaScript-free uploader.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
The JavaScript-free uploader doesn't care about browser features too
much, specifically about window.FormData. That API is for JavaScript.
Because there also isn't any JavaScript to execute, this template never
gets called. It's dead HTML, so remove it.
|
|
Fix some 404 and outdated links in the tools page.
- Update ShareX URL and settings
- Update Gyazowin source code link
- Rename Gyazo Client to Gyazowin for simplicity
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Fix some 404 and outdated links in the tools page.
- Update ShareX URL and settings
- Update Gyazowin source code link
- Rename Gyazo Client to Gyazowin for simplicity
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Acked-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
Acked-by: Eliot Whalan <ewhal@pantsu.cat>
|
|
This outline-offset value has been commented out for how long, and it
seems to have no purpose. Remove it.
Signed-off-by: Juuso Lapinlampi <wub@partyvan.eu>
|
|
Replaces js/pomf.js and its dependencies with Luminarys' new js/app.js,
written in vanilla JavaScript with no dependencies required. This should
improve browser backwards compatibility.
Includes patches from wub@ to add Luminarys to package.json contributors
and adding the proper copyright header to js/app.js.
Luminarys' original code had removed an unused CSS property from
css/pomf.css. I reverted this change to merge it later as a seperate
fix, to be able to merge it properly to the maint branch.
|
|
Adds Luminarys <postmaster@gensok.io> to package.json contributors list.
Luminarys initially committed js/app.js, the new client-side code for
Pomf to replace the old js/pomf.js. This was a significant contribution.
|
|
Adds "Copyright (c) 2016 Luminarys <postmaster@gensok.io>" to js/app.js
with the Expat license embedded.
|
|
Pomf's old JavaScript is a frozen dependency hell with an old version of
Zepto. The amount of code included has reached the point of
unmaintainability, where nobody really understands very well how the
code works.
This code gets rid of all the previous client-side JavaScript and
replaces it with new, vanilla JavaScript. No dependencies required. This
new JavaScript should be quite a bit faster too.
Browser backwards compatibility has not been tested yet, however it is
expected that IE10 and later will work, improving our current backwards
compatibility.
Reviewed-by: Eliot Whalan <ewhal@pantsu.cat>
[wub@partyvan.eu: Added Git commit message and fixed Git branching.
Reverted /* outline-offset: -2px;*/ removal.]
Signed-off-by: Juuso Lapinlampi <wub@partyvan.eu>
|
|
"Gyazo Client (Puush like client)" is a horrible word monster. In the
Pomf community, it is better known as Gyazowin which refers to the
actual project and repository name.
Call it Gyazowin from now on in the tools page.
|
|
Pantsu.cat's fork of Gyazowin (aka "Gyazo Client (Puush like client)")
had moved its development to git.pantsu.cat somewhere around September
23, 2015. This link to GitHub is now dead (404 Not Found).
Replace it with the repository hosted on git.pantsu.cat, at least until
ewhal@ decides to get rid of that unmaintained repository.
Reported-by: Jaex
|
|
ShareX has moved its source code repository to GitHub. Google Code is
also shutting down, so update and point the URL to the GitHub
repository.
While we are here, update and sanitize the ShareX settings we need to
use. Also update the copyright year in header.
Reported-by: Jaex
Suggested-by: Jaex
|
|
We are ready to release Pomf 2.0.0. Patches will follow semantic
versioning, so th next 2.0 branch release will be 2.0.1. The next
feature release will be the 2.1 branch with release 2.1.0.
OK ewhal@
|
|
New code has been added to Response.class.php this year in commit
b94ac9a. Update LICENSE and Response.class.php copyright header with
year 2016.
We can't do this for every file in the project repository unless they
are actually changed, due to the way our copyright legislation works. We
also can't remove the mention of 2015, because most of the code was
initially published in 2015 and so remains copyrighted since that year.
|
|
Clean up a lot of the cruft in Response class.
Gyazo is deprecated and falls back to 'text' for similar functionality,
reducing code duplication. It will be removed in a future release.
CSV gets a text/csv Content-Type. CSV linebreaks are also now CRLF, and
values are wrapped in quotes.
The default error is now a JSON response instead of a generic 400 Bad
Request in plaintext.
output=json is now explicit and no longer undefined behavior.
|
|
The gyazo response would return an empty response, because the construct
didn't actually fallthrough to text properly. Force gyazo's response
type to be 'text' to fix the issue.
Accordingly, the 'gyazo' cases for send() and error() now become dead
code. Remove them.
OK ewhal@
|
|
Add myself to package.json contributors. I have a significant amount of
code and effort dedicated to this project, so I can be contacted for
questions.
OK ewhal@
|
|
Lint our spaghetti JavaScript code to be at least slightly more
readable. Configuration used is ESLint 1.7.x and airbnb/legacy.
It's been so long I cannot remember every change that was done, but long
story short: all the ESLint errors are now gone, at least at the date of
last commit.
moep contributed some ideas for patches: some were implemented, some
were discarded as the time and patience for merging this ran out. Thus,
there are still ESLint warnings about anonymous functions.
I don't feel like spending much more time on this. The future Pomf 2.1
development branch will replace the JavaScript code in its entirety,
courtesy of luminarys@.
Suggested-by: moep
Tested-by: Eliot Whalan <ewhal@pantsu.cat>
OK ewhal@, maybe a vague OK from luminarys@ a long time ago
|
|
|
|
Reword the "no Git issue tracking" policy in contributing section.
Previously the contributing section in README.md would say we don't use
git.pantsu.cat's issue tracker to track issues. That Git service
repository's issues have been disabled today, so we might as well say we
don't use any Git service issue tracking. Unofficial mirrors like the
one on notabug.org may still have issue tracking, which I believe we
have no control over.
This commit also clarifies that we do it for ethical and technical
objections. (In short, it's because the Git service is centralized and a
walled garden.) For more information, see
wubthecaptain/deathwatch-pomf@fc86cbf for information why.
|
|
Peter Lejeck's (peter.lejeck@) only commit in the file is a507748, which
is pretty much just the HTML layout in the file. I have changed that, a
lot.
Eric Johansson's (neku@) commits in the file covered the text itself.
This too has been replaced in commit 7d61e04, which rewrote all the
text in the page.
In other words, these two authors no longer have any meaningful content
in the file to be attributed. Much of the copyright goes to the
Pantsu.cat developers - which covers myself too.
OK luminarys@, "no complaints"
|
|
Fixup to previous commit 120627d. Fixes Grunt build failure.
Gladly, I am working on replacing Grunt with Makefile for 2.1.0 or 3.0.0
release so that these mistakes should happen less frequently.
|
|
Catalan translation was removed in commit 566611c. However, the commit
was incomplete and forgot to remove the swig build task from Grunt.
We can safely remove these Catalan pages from Grunt swig build. They no
longer exist and this is dead code.
OK luminarys@
|
|
Previous commit c950e85 came with a workaround to resolve a TypeError in
EventEmitter.prototype.emit for-loop. That workaround sacrificed some
readability for bug fixing due to technical debt.
bursey came up with a better solution on IRC which seems to work and
improves readability. Something needs to emit an event that wasn't bound
with "on", thus the event was not in the _events object.
Airbnb ES5 style guide requires to have all variables at top, so we
leave the len variable undefined at the top to be defined later. After
the _events check, we define len to avoid the TypeError issue while
conforming to Airbnb ES5 style guide and improving readability.
This commit also adds comments to document the function.
Suggested-by: bursey (#/g/partyvan @ Partyvan IRC)
|
|
this._events[evt].length would run into JavaScript scope issues in
EventEmitter.prototype.emit function for-loop.
This is an attempt to work around the issue to resolve an innocent
looking TypeError. The code seems to work without this patch, but I
can't spot if this is some dead code or know what to do with it. Due to
technical debt, some sacrifice had to be made in readability for fixing
this bug.
This bug was introduced in commit 575b78b.
For future improvement, this function and other functions in the file
should be refactored or replaced with a more efficient implementation.
|
|
Very short identifier names usually make the code harder to read and
potentially less maintainable.
Fixes two ESLint id-length errors using airbnb/legacy config.
Suggested-by: avail <avail@pomf.se>
|
|
- Rephrase check_script.swig JavaScript warning
- Remove check_script URL dependency to no.pantsu.cat
OK ewhal@
|
|
check_script.swig would hardlink to no.pantsu.cat domain for the purpose
of Catalan translations as part of a hack. Catalan translations were
removed in commit 566611c, so we can link to the nojs.html page directly
(built at compile time).
This assures that all sites using this project's code will have less to
tweak to make this project work on their site.
|
|
Clarify that the site requires JavaScript to function and what the user
should do. Telling the users only "Javascript free version" is confusing
at best, and we can do better.
For future improvement, the JavaScript-free version may be integrated on
the same page as the JavaScript uploader.
|
|
When a local variable shares the same name with a variable in its scope,
it can cause confusion to the reader and make it impossible to access
the global variable.
Disallow shadowing. Fixes ESLint no-shadow errors using airbnb/legacy
config.
Suggested-by: marc <mharnos@gmail.com>
|
