<feed xmlns='http://www.w3.org/2005/Atom'>
<title>pomf/static/upload.php, branch master</title>
<subtitle>[no description]</subtitle>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/'/>
<entry>
<title>Create php file</title>
<updated>2016-06-17T08:42:24+00:00</updated>
<author>
<name>Eliot Whalan</name>
<email>ewhal@pantsu.cat</email>
</author>
<published>2016-06-17T08:42:24+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=a3643179b262005d2cd251fb4defb3884ab814ae'/>
<id>a3643179b262005d2cd251fb4defb3884ab814ae</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Rename all functions to camelCase as set by psr2</title>
<updated>2016-06-17T03:15:02+00:00</updated>
<author>
<name>Eliot Whalan</name>
<email>ewhal@pantsu.cat</email>
</author>
<published>2016-06-17T03:15:02+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=c42d0ec5c05f430e4454aab9b05932067b94bcb7'/>
<id>c42d0ec5c05f430e4454aab9b05932067b94bcb7</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert most ofddccf5f1c26517bf58cd45e3d92096fc760d9db6</title>
<updated>2016-06-15T22:02:17+00:00</updated>
<author>
<name>Eliot Whalan</name>
<email>ewhal@pantsu.cat</email>
</author>
<published>2016-06-15T22:02:17+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=9f87469d24b6002704f7d16eca0be77e54d5f294'/>
<id>9f87469d24b6002704f7d16eca0be77e54d5f294</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "upload.php: Deprecate all named functions"</title>
<updated>2016-06-14T06:55:07+00:00</updated>
<author>
<name>Eliot Whalan</name>
<email>ewhal@pantsu.cat</email>
</author>
<published>2016-06-14T06:55:07+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=d16a49a74aaf0edabcb99fd9c7f9f58411ab032e'/>
<id>d16a49a74aaf0edabcb99fd9c7f9f58411ab032e</id>
<content type='text'>
This reverts commit cae3cb012812c2d7e1995301e85c8954567a499d.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts commit cae3cb012812c2d7e1995301e85c8954567a499d.
</pre>
</div>
</content>
</entry>
<entry>
<title>upload.php: Deprecate all named functions</title>
<updated>2016-05-29T15:26:36+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2016-05-29T15:26:36+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=cae3cb012812c2d7e1995301e85c8954567a499d'/>
<id>cae3cb012812c2d7e1995301e85c8954567a499d</id>
<content type='text'>
Deprecates diverse_array(), generate_name(), refiles() and
upload_file(). These pollute the global namespace and do not follow the
PSR-2 naming convention.

The plan is to create a new file with a new class to share this common
code, leaving upload.php only with the last lines of code that it really
needs to do (calling other class functions).

Acked-by: Eliot Whalan &lt;ewhal@pantsu.cat&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Deprecates diverse_array(), generate_name(), refiles() and
upload_file(). These pollute the global namespace and do not follow the
PSR-2 naming convention.

The plan is to create a new file with a new class to share this common
code, leaving upload.php only with the last lines of code that it really
needs to do (calling other class functions).

Acked-by: Eliot Whalan &lt;ewhal@pantsu.cat&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>upload.php: Don't unlink() tempfiles in upload_file()</title>
<updated>2016-05-29T13:48:46+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2016-05-29T13:39:25+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=19a3645c2415bbe45c0a6cadd003d7b3ef04a630'/>
<id>19a3645c2415bbe45c0a6cadd003d7b3ef04a630</id>
<content type='text'>
We don't need to care about garbage collection and explicitly unlinking
temporary files: PHP will handle that for us automatically. In other
words, this is "dead" code. Less code the better.

Updates the comment before it to reflect this.

Tested on PHP 5.6.22 and PHP 7.0.7 on Debian stretch/sid GNU/Linux.

Tested-by: Juuso Lapinlampi &lt;wub@partyvan.eu&gt;
See: https://secure.php.net/manual/en/function.tmpfile.php
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We don't need to care about garbage collection and explicitly unlinking
temporary files: PHP will handle that for us automatically. In other
words, this is "dead" code. Less code the better.

Updates the comment before it to reflect this.

Tested on PHP 5.6.22 and PHP 7.0.7 on Debian stretch/sid GNU/Linux.

Tested-by: Juuso Lapinlampi &lt;wub@partyvan.eu&gt;
See: https://secure.php.net/manual/en/function.tmpfile.php
</pre>
</div>
</content>
</entry>
<entry>
<title>upload.php: Deprecate ob_start (output buffering)</title>
<updated>2016-05-25T04:53:00+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2016-05-25T04:35:52+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=f4504ac1229c0f0064fc5a7f80ebbd8a98427213'/>
<id>f4504ac1229c0f0064fc5a7f80ebbd8a98427213</id>
<content type='text'>
None of us can find a reason why we would need to buffer our output in a
PHP application. My best guess is this may be a relic from Pomf 1.0.0 or
Moe panel.

Unless someone finds a better reason to keep this, this feature is
useless and has negligible benefit and will be removed.

In respect for SemVer, deprecating this feature happens first in a minor
version before removal in a next major version.

Acked-by: Eliot Whalan &lt;ewhal@pantsu.cat&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
None of us can find a reason why we would need to buffer our output in a
PHP application. My best guess is this may be a relic from Pomf 1.0.0 or
Moe panel.

Unless someone finds a better reason to keep this, this feature is
useless and has negligible benefit and will be removed.

In respect for SemVer, deprecating this feature happens first in a minor
version before removal in a next major version.

Acked-by: Eliot Whalan &lt;ewhal@pantsu.cat&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>upload.php: Clarify what Exception $code 500 is</title>
<updated>2016-05-25T04:15:42+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2016-05-25T04:02:56+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=8b23ebc05eba911e0c885e38b4f05d2e42e6be04'/>
<id>8b23ebc05eba911e0c885e38b4f05d2e42e6be04</id>
<content type='text'>
Add comments explaining how the number 500 after Exception means HTTP
status code "500 Internal Server Error". This may not be so obvious to
the reader without consulting the PHP manual.

Compliments commit 4606553f38909b483bc06674f9558ede1a9ff1f6.

Reviewed-by: Eliot Whalan &lt;ewhal@pantsu.cat&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add comments explaining how the number 500 after Exception means HTTP
status code "500 Internal Server Error". This may not be so obvious to
the reader without consulting the PHP manual.

Compliments commit 4606553f38909b483bc06674f9558ede1a9ff1f6.

Reviewed-by: Eliot Whalan &lt;ewhal@pantsu.cat&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Extend and improve PHP code comments (PHPDoc)</title>
<updated>2016-05-24T19:19:22+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2016-05-23T21:02:39+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=2fc3fbb41dbd81a92dfe27a22b31f36b10ea37ca'/>
<id>2fc3fbb41dbd81a92dfe27a22b31f36b10ea37ca</id>
<content type='text'>
Add file summaries, @copyright tags and other comments. Covers majority
of the PHP code base now. I have avoided being too verbose and omitted
some potential tags.

Most visibly to the user, this comments every user configurable setting
and clarifies what some of the options do.

POMF_DB_USER and POMF_DB_PASS are not rendered perfectly in
phpDocumentor version 2.8.5. This is a sacrifice I made in attempt for
not being too verbose and obvious.

Response class gets a @todo for being a god object.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add file summaries, @copyright tags and other comments. Covers majority
of the PHP code base now. I have avoided being too verbose and omitted
some potential tags.

Most visibly to the user, this comments every user configurable setting
and clarifies what some of the options do.

POMF_DB_USER and POMF_DB_PASS are not rendered perfectly in
phpDocumentor version 2.8.5. This is a sacrifice I made in attempt for
not being too verbose and obvious.

Response class gets a @todo for being a god object.
</pre>
</div>
</content>
</entry>
<entry>
<title>Replace include_once statements with require_once</title>
<updated>2016-05-23T01:50:27+00:00</updated>
<author>
<name>Austin Gillmann</name>
<email>alucard@cuntflaps.me</email>
</author>
<published>2016-05-23T01:03:38+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=349087a478704257ec86561dc774c358ab760c64'/>
<id>349087a478704257ec86561dc774c358ab760c64</id>
<content type='text'>
Normally in include_once if a script does not load PHP will treat it as
such as an E_WARNING, while require_once fail the script with a
E_COMPILE_ERROR if the script does not load.

Since we require all of these scripts to properly function it
will be better to classify them as required in PHP.

Reported-by: Juuso Lapinlampi &lt;wub@partyvan.eu&gt;
Reviewed-by: Juuso Lapinlampi &lt;wub@partyvan.eu&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Normally in include_once if a script does not load PHP will treat it as
such as an E_WARNING, while require_once fail the script with a
E_COMPILE_ERROR if the script does not load.

Since we require all of these scripts to properly function it
will be better to classify them as required in PHP.

Reported-by: Juuso Lapinlampi &lt;wub@partyvan.eu&gt;
Reviewed-by: Juuso Lapinlampi &lt;wub@partyvan.eu&gt;
</pre>
</div>
</content>
</entry>
</feed>
