<feed xmlns='http://www.w3.org/2005/Atom'>
<title>pomf/js/pomf.js, branch master</title>
<subtitle>[no description]</subtitle>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/'/>
<entry>
<title>Replace old JavaScript with simpler vanilla version</title>
<updated>2016-01-17T16:26:03+00:00</updated>
<author>
<name>Luminarys</name>
<email>postmaster@gensok.io</email>
</author>
<published>2016-01-17T10:54:39+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=bfa395944520c13064a26f3f94487131598503ab'/>
<id>bfa395944520c13064a26f3f94487131598503ab</id>
<content type='text'>
Pomf's old JavaScript is a frozen dependency hell with an old version of
Zepto. The amount of code included has reached the point of
unmaintainability, where nobody really understands very well how the
code works.

This code gets rid of all the previous client-side JavaScript and
replaces it with new, vanilla JavaScript. No dependencies required. This
new JavaScript should be quite a bit faster too.

Browser backwards compatibility has not been tested yet, however it is
expected that IE10 and later will work, improving our current backwards
compatibility.

Reviewed-by: Eliot Whalan &lt;ewhal@pantsu.cat&gt;
[wub@partyvan.eu: Added Git commit message and fixed Git branching.
Reverted /*   outline-offset: -2px;*/ removal.]
Signed-off-by: Juuso Lapinlampi &lt;wub@partyvan.eu&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Pomf's old JavaScript is a frozen dependency hell with an old version of
Zepto. The amount of code included has reached the point of
unmaintainability, where nobody really understands very well how the
code works.

This code gets rid of all the previous client-side JavaScript and
replaces it with new, vanilla JavaScript. No dependencies required. This
new JavaScript should be quite a bit faster too.

Browser backwards compatibility has not been tested yet, however it is
expected that IE10 and later will work, improving our current backwards
compatibility.

Reviewed-by: Eliot Whalan &lt;ewhal@pantsu.cat&gt;
[wub@partyvan.eu: Added Git commit message and fixed Git branching.
Reverted /*   outline-offset: -2px;*/ removal.]
Signed-off-by: Juuso Lapinlampi &lt;wub@partyvan.eu&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix-eslint-warnings-2' of wubthecaptain/pomf</title>
<updated>2016-01-06T10:51:06+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2016-01-06T10:51:06+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=d601676c6c34a2ef6cbb3f00bdd8c0ae7eef6c08'/>
<id>d601676c6c34a2ef6cbb3f00bdd8c0ae7eef6c08</id>
<content type='text'>
Lint our spaghetti JavaScript code to be at least slightly more
readable. Configuration used is ESLint 1.7.x and airbnb/legacy.

It's been so long I cannot remember every change that was done, but long
story short: all the ESLint errors are now gone, at least at the date of
last commit.

moep contributed some ideas for patches: some were implemented, some
were discarded as the time and patience for merging this ran out. Thus,
there are still ESLint warnings about anonymous functions.

I don't feel like spending much more time on this. The future Pomf 2.1
development branch will replace the JavaScript code in its entirety,
courtesy of luminarys@.

Suggested-by: moep
Tested-by: Eliot Whalan &lt;ewhal@pantsu.cat&gt;

OK ewhal@, maybe a vague OK from luminarys@ a long time ago
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Lint our spaghetti JavaScript code to be at least slightly more
readable. Configuration used is ESLint 1.7.x and airbnb/legacy.

It's been so long I cannot remember every change that was done, but long
story short: all the ESLint errors are now gone, at least at the date of
last commit.

moep contributed some ideas for patches: some were implemented, some
were discarded as the time and patience for merging this ran out. Thus,
there are still ESLint warnings about anonymous functions.

I don't feel like spending much more time on this. The future Pomf 2.1
development branch will replace the JavaScript code in its entirety,
courtesy of luminarys@.

Suggested-by: moep
Tested-by: Eliot Whalan &lt;ewhal@pantsu.cat&gt;

OK ewhal@, maybe a vague OK from luminarys@ a long time ago
</pre>
</div>
</content>
</entry>
<entry>
<title>Rename local variables to unique private names</title>
<updated>2015-11-18T12:24:32+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2015-11-18T12:24:32+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=d527b2d6769bdc0d2cd6744f1bda9d8da74ef6a6'/>
<id>d527b2d6769bdc0d2cd6744f1bda9d8da74ef6a6</id>
<content type='text'>
When a local variable shares the same name with a variable in its scope,
it can cause confusion to the reader and make it impossible to access
the global variable.

Disallow shadowing. Fixes ESLint no-shadow errors using airbnb/legacy
config.

Suggested-by: marc &lt;mharnos@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When a local variable shares the same name with a variable in its scope,
it can cause confusion to the reader and make it impossible to access
the global variable.

Disallow shadowing. Fixes ESLint no-shadow errors using airbnb/legacy
config.

Suggested-by: marc &lt;mharnos@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove unused JavaScript variables (no-unused-vars)</title>
<updated>2015-11-18T11:54:42+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2015-11-18T11:54:42+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=f413dc9a1b944fd653c3bc089516c3363fb57857'/>
<id>f413dc9a1b944fd653c3bc089516c3363fb57857</id>
<content type='text'>
Quoting ESLint:

&gt; Variables that are declared and not used anywhere in the code are most
&gt; likely an error due to incomplete refactoring. Such variables take up
&gt; space in the code and can lead to confusion by readers.

This commit removes them. Fixes ESLint no-unused-vars errors using
airbnb/legacy config.

Suggested-by: marc &lt;mharnos@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Quoting ESLint:

&gt; Variables that are declared and not used anywhere in the code are most
&gt; likely an error due to incomplete refactoring. Such variables take up
&gt; space in the code and can lead to confusion by readers.

This commit removes them. Fixes ESLint no-unused-vars errors using
airbnb/legacy config.

Suggested-by: marc &lt;mharnos@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert default max-file-size from 120MiB to 10MiB</title>
<updated>2015-10-27T14:57:13+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2015-10-27T14:57:13+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=b8259ef32c861e483d6c6beef4d5f8f2dc475bdf'/>
<id>b8259ef32c861e483d6c6beef4d5f8f2dc475bdf</id>
<content type='text'>
ewhal@ didn't understand how changing the maximum file size works, so he
edited the JavaScript code directly to set the default to his desired
120MiB.

For all clones, this may not be viable and it's not a sane default in my
opinion. This doesn't change the fact that the maximum file size remains
to be what it's configured in the configuration (Gruntfile.js).

This bug was introduced in commit ec0154b, and potentially others.

Vague OK from ewhal@ many weeks ago.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
ewhal@ didn't understand how changing the maximum file size works, so he
edited the JavaScript code directly to set the default to his desired
120MiB.

For all clones, this may not be viable and it's not a sane default in my
opinion. This doesn't change the fact that the maximum file size remains
to be what it's configured in the configuration (Gruntfile.js).

This bug was introduced in commit ec0154b, and potentially others.

Vague OK from ewhal@ many weeks ago.
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove all JSHint tools and headers</title>
<updated>2015-10-13T16:10:29+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2015-10-13T16:10:29+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=423774190afd6568c709d1cd1b93858a74830f2d'/>
<id>423774190afd6568c709d1cd1b93858a74830f2d</id>
<content type='text'>
JSHint is "deprecated" in favor of ESLint. Personally I have not used
JSHint ever since switching to ESLint.

Vague OK from ewhal@
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
JSHint is "deprecated" in favor of ESLint. Personally I have not used
JSHint ever since switching to ESLint.

Vague OK from ewhal@
</pre>
</div>
</content>
</entry>
<entry>
<title>Add missing newline introduced in previous commit</title>
<updated>2015-10-09T16:04:58+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2015-10-09T16:04:58+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=25109de5f34842de0ea7a80e1a9f3e9c57e68e34'/>
<id>25109de5f34842de0ea7a80e1a9f3e9c57e68e34</id>
<content type='text'>
Before this, JSCS would print an error about missing newline. This was
introduced in previous commit 24ce733.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Before this, JSCS would print an error about missing newline. This was
introduced in previous commit 24ce733.
</pre>
</div>
</content>
</entry>
<entry>
<title>Lint pomf.js vars declarations to top of function</title>
<updated>2015-10-09T15:59:48+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2015-10-09T15:59:48+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=24ce733985f9d220067654e51698b41c4b446fe7'/>
<id>24ce733985f9d220067654e51698b41c4b446fe7</id>
<content type='text'>
Fixes ESLint vars-on-top errors using airbnb/legacy config.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes ESLint vars-on-top errors using airbnb/legacy config.
</pre>
</div>
</content>
</entry>
<entry>
<title>Lint pomf.js ID length to &gt; 2 characters</title>
<updated>2015-10-09T14:00:31+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2015-10-09T13:59:32+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=59502c86ceba164c3ccf1a7fa58bf33560157d2b'/>
<id>59502c86ceba164c3ccf1a7fa58bf33560157d2b</id>
<content type='text'>
Fixes ESLint id-length errors using airbnb/legacy config. Some arguments
were also unused, so this will also avoid introducing new no-unused-vars
lint errors.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes ESLint id-length errors using airbnb/legacy config. Some arguments
were also unused, so this will also avoid introducing new no-unused-vars
lint errors.
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove extra whitespace in variable declarations</title>
<updated>2015-10-04T18:02:53+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2015-10-04T18:02:53+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=9bdedb32e61159a78fd9717fdaacf63405fe9e98'/>
<id>9bdedb32e61159a78fd9717fdaacf63405fe9e98</id>
<content type='text'>
This is something I would disagree with, because this commit in my
opinion reduces readability. I am not going to reinvent the wheel and
write for humans, because I enjoy being a slave to ESLint.

Any complaints about this commit should be directed at Airbnb to fix
their style guide. Alternatively, a documented standard style guide
should be created for pantsu.cat, extending the Airbnb config.

This fixes ESLint no-multi-spaces errors using airbnb/legacy config.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is something I would disagree with, because this commit in my
opinion reduces readability. I am not going to reinvent the wheel and
write for humans, because I enjoy being a slave to ESLint.

Any complaints about this commit should be directed at Airbnb to fix
their style guide. Alternatively, a documented standard style guide
should be created for pantsu.cat, extending the Airbnb config.

This fixes ESLint no-multi-spaces errors using airbnb/legacy config.
</pre>
</div>
</content>
</entry>
</feed>
