<feed xmlns='http://www.w3.org/2005/Atom'>
<title>pomf/js/cheesesteak.js, branch master</title>
<subtitle>[no description]</subtitle>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/'/>
<entry>
<title>Replace old JavaScript with simpler vanilla version</title>
<updated>2016-01-17T16:26:03+00:00</updated>
<author>
<name>Luminarys</name>
<email>postmaster@gensok.io</email>
</author>
<published>2016-01-17T10:54:39+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=bfa395944520c13064a26f3f94487131598503ab'/>
<id>bfa395944520c13064a26f3f94487131598503ab</id>
<content type='text'>
Pomf's old JavaScript is a frozen dependency hell with an old version of
Zepto. The amount of code included has reached the point of
unmaintainability, where nobody really understands very well how the
code works.

This code gets rid of all the previous client-side JavaScript and
replaces it with new, vanilla JavaScript. No dependencies required. This
new JavaScript should be quite a bit faster too.

Browser backwards compatibility has not been tested yet, however it is
expected that IE10 and later will work, improving our current backwards
compatibility.

Reviewed-by: Eliot Whalan &lt;ewhal@pantsu.cat&gt;
[wub@partyvan.eu: Added Git commit message and fixed Git branching.
Reverted /*   outline-offset: -2px;*/ removal.]
Signed-off-by: Juuso Lapinlampi &lt;wub@partyvan.eu&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Pomf's old JavaScript is a frozen dependency hell with an old version of
Zepto. The amount of code included has reached the point of
unmaintainability, where nobody really understands very well how the
code works.

This code gets rid of all the previous client-side JavaScript and
replaces it with new, vanilla JavaScript. No dependencies required. This
new JavaScript should be quite a bit faster too.

Browser backwards compatibility has not been tested yet, however it is
expected that IE10 and later will work, improving our current backwards
compatibility.

Reviewed-by: Eliot Whalan &lt;ewhal@pantsu.cat&gt;
[wub@partyvan.eu: Added Git commit message and fixed Git branching.
Reverted /*   outline-offset: -2px;*/ removal.]
Signed-off-by: Juuso Lapinlampi &lt;wub@partyvan.eu&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix-eslint-warnings-2' of wubthecaptain/pomf</title>
<updated>2016-01-06T10:51:06+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2016-01-06T10:51:06+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=d601676c6c34a2ef6cbb3f00bdd8c0ae7eef6c08'/>
<id>d601676c6c34a2ef6cbb3f00bdd8c0ae7eef6c08</id>
<content type='text'>
Lint our spaghetti JavaScript code to be at least slightly more
readable. Configuration used is ESLint 1.7.x and airbnb/legacy.

It's been so long I cannot remember every change that was done, but long
story short: all the ESLint errors are now gone, at least at the date of
last commit.

moep contributed some ideas for patches: some were implemented, some
were discarded as the time and patience for merging this ran out. Thus,
there are still ESLint warnings about anonymous functions.

I don't feel like spending much more time on this. The future Pomf 2.1
development branch will replace the JavaScript code in its entirety,
courtesy of luminarys@.

Suggested-by: moep
Tested-by: Eliot Whalan &lt;ewhal@pantsu.cat&gt;

OK ewhal@, maybe a vague OK from luminarys@ a long time ago
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Lint our spaghetti JavaScript code to be at least slightly more
readable. Configuration used is ESLint 1.7.x and airbnb/legacy.

It's been so long I cannot remember every change that was done, but long
story short: all the ESLint errors are now gone, at least at the date of
last commit.

moep contributed some ideas for patches: some were implemented, some
were discarded as the time and patience for merging this ran out. Thus,
there are still ESLint warnings about anonymous functions.

I don't feel like spending much more time on this. The future Pomf 2.1
development branch will replace the JavaScript code in its entirety,
courtesy of luminarys@.

Suggested-by: moep
Tested-by: Eliot Whalan &lt;ewhal@pantsu.cat&gt;

OK ewhal@, maybe a vague OK from luminarys@ a long time ago
</pre>
</div>
</content>
</entry>
<entry>
<title>Refactor cheesesteak.js EventEmitter emit function</title>
<updated>2015-11-18T16:47:30+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2015-11-18T16:24:14+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=c257a1c1d63197f5349c12962558eccc7837a0f5'/>
<id>c257a1c1d63197f5349c12962558eccc7837a0f5</id>
<content type='text'>
Previous commit c950e85 came with a workaround to resolve a TypeError in
EventEmitter.prototype.emit for-loop. That workaround sacrificed some
readability for bug fixing due to technical debt.

bursey came up with a better solution on IRC which seems to work and
improves readability. Something needs to emit an event that wasn't bound
with "on", thus the event was not in the _events object.

Airbnb ES5 style guide requires to have all variables at top, so we
leave the len variable undefined at the top to be defined later. After
the _events check, we define len to avoid the TypeError issue while
conforming to Airbnb ES5 style guide and improving readability.

This commit also adds comments to document the function.

Suggested-by: bursey (#/g/partyvan @ Partyvan IRC)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previous commit c950e85 came with a workaround to resolve a TypeError in
EventEmitter.prototype.emit for-loop. That workaround sacrificed some
readability for bug fixing due to technical debt.

bursey came up with a better solution on IRC which seems to work and
improves readability. Something needs to emit an event that wasn't bound
with "on", thus the event was not in the _events object.

Airbnb ES5 style guide requires to have all variables at top, so we
leave the len variable undefined at the top to be defined later. After
the _events check, we define len to avoid the TypeError issue while
conforming to Airbnb ES5 style guide and improving readability.

This commit also adds comments to document the function.

Suggested-by: bursey (#/g/partyvan @ Partyvan IRC)
</pre>
</div>
</content>
</entry>
<entry>
<title>Workaround undefined length TypeError in cheesesteak</title>
<updated>2015-11-18T15:42:31+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2015-11-18T15:42:31+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=c950e85c8248800f321e280c16a48f15a35e8d4a'/>
<id>c950e85c8248800f321e280c16a48f15a35e8d4a</id>
<content type='text'>
this._events[evt].length would run into JavaScript scope issues in
EventEmitter.prototype.emit function for-loop.

This is an attempt to work around the issue to resolve an innocent
looking TypeError. The code seems to work without this patch, but I
can't spot if this is some dead code or know what to do with it. Due to
technical debt, some sacrifice had to be made in readability for fixing
this bug.

This bug was introduced in commit 575b78b.

For future improvement, this function and other functions in the file
should be refactored or replaced with a more efficient implementation.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
this._events[evt].length would run into JavaScript scope issues in
EventEmitter.prototype.emit function for-loop.

This is an attempt to work around the issue to resolve an innocent
looking TypeError. The code seems to work without this patch, but I
can't spot if this is some dead code or know what to do with it. Due to
technical debt, some sacrifice had to be made in readability for fixing
this bug.

This bug was introduced in commit 575b78b.

For future improvement, this function and other functions in the file
should be refactored or replaced with a more efficient implementation.
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove unused JavaScript variables (no-unused-vars)</title>
<updated>2015-11-18T11:54:42+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2015-11-18T11:54:42+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=f413dc9a1b944fd653c3bc089516c3363fb57857'/>
<id>f413dc9a1b944fd653c3bc089516c3363fb57857</id>
<content type='text'>
Quoting ESLint:

&gt; Variables that are declared and not used anywhere in the code are most
&gt; likely an error due to incomplete refactoring. Such variables take up
&gt; space in the code and can lead to confusion by readers.

This commit removes them. Fixes ESLint no-unused-vars errors using
airbnb/legacy config.

Suggested-by: marc &lt;mharnos@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Quoting ESLint:

&gt; Variables that are declared and not used anywhere in the code are most
&gt; likely an error due to incomplete refactoring. Such variables take up
&gt; space in the code and can lead to confusion by readers.

This commit removes them. Fixes ESLint no-unused-vars errors using
airbnb/legacy config.

Suggested-by: marc &lt;mharnos@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove all JSHint tools and headers</title>
<updated>2015-10-13T16:10:29+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2015-10-13T16:10:29+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=423774190afd6568c709d1cd1b93858a74830f2d'/>
<id>423774190afd6568c709d1cd1b93858a74830f2d</id>
<content type='text'>
JSHint is "deprecated" in favor of ESLint. Personally I have not used
JSHint ever since switching to ESLint.

Vague OK from ewhal@
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
JSHint is "deprecated" in favor of ESLint. Personally I have not used
JSHint ever since switching to ESLint.

Vague OK from ewhal@
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix JSCS missing newline errors</title>
<updated>2015-10-11T16:32:38+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2015-10-11T16:32:08+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=251b4d789d13e39436937e98500c5c5e2ab4d427'/>
<id>251b4d789d13e39436937e98500c5c5e2ab4d427</id>
<content type='text'>
Using preset "airbnb".
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Using preset "airbnb".
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'eslint-vars-on-top' into fix-eslint-warnings-2</title>
<updated>2015-10-11T16:25:16+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2015-10-11T16:25:16+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=c54fc2bcd9d96ad622a299d33779f51bab03230b'/>
<id>c54fc2bcd9d96ad622a299d33779f51bab03230b</id>
<content type='text'>
Fixes ESLint vars-on-top errors using airbnb/legacy config.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes ESLint vars-on-top errors using airbnb/legacy config.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'eslint-id-length' into fix-eslint-warnings-2</title>
<updated>2015-10-11T16:21:51+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2015-10-11T16:21:51+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=7bb7029eb356dfc769cf71d40a9d5b31cafa6f53'/>
<id>7bb7029eb356dfc769cf71d40a9d5b31cafa6f53</id>
<content type='text'>
Fixes ESLint id-length warnings. An exception is given to var "i",
because Airbnb's style guide says this is OK. A bug is in
eslint-config-airbnb, which the Airbnb style guide authors have not as
of today accepted to merge to fix the bug.

var "$" will be fixed later.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes ESLint id-length warnings. An exception is given to var "i",
because Airbnb's style guide says this is OK. A bug is in
eslint-config-airbnb, which the Airbnb style guide authors have not as
of today accepted to merge to fix the bug.

var "$" will be fixed later.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'refactor-cheesesteak' into fix-eslint-warnings-2</title>
<updated>2015-10-11T16:17:42+00:00</updated>
<author>
<name>Juuso Lapinlampi</name>
<email>wub@partyvan.eu</email>
</author>
<published>2015-10-11T16:17:42+00:00</published>
<link rel='alternate' type='text/html' href='http://repo2.mydevil.net/git/pub/wandystan/pomf/commit/?id=6d93e72a544440d7c4cb0609cf6a3dc0f801f5f4'/>
<id>6d93e72a544440d7c4cb0609cf6a3dc0f801f5f4</id>
<content type='text'>
Events now fire faster. Fixes ESLint func-names warnings using
airbnb/legacy config.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Events now fire faster. Fixes ESLint func-names warnings using
airbnb/legacy config.
</pre>
</div>
</content>
</entry>
</feed>
